Repository navigation
Commit 58341d8
[Chore] Turn off unused-variable linting in src and remove dead code (#2038)
* chore(eslint): turn off no-unused-vars in src and remove dead code
Turn off both no-unused-vars and @typescript-eslint/no-unused-vars in
src/eslint.config.mjs, and clean up all existing violations so the tree
stays tidy without the rule:
- Remove unused imports across src (autofixed, then hand-reviewed).
- Remove unused local variables, functions, interfaces, and type aliases.
- Convert unused catch bindings to optional catch binding (catch { ... }).
- Prefix intentionally unused function parameters with _ per the existing
argsIgnorePattern convention, and drop unused destructured properties.
- Remove never-read private members and convert never-read constructor
parameter properties to plain parameters.
- Prune reduced counts in eslint-suppressions.json (counts only decreased).
No behavior changes: side-effecting calls whose results were unused are
kept as expression statements.
Validated with:
- eslint with @typescript-eslint/no-unused-vars forced on: zero findings.
- tsc --noEmit --noUnusedLocals --noUnusedParameters cross-check: clean.
- pnpm lint, pnpm check-types, pnpm test (root, all workspaces): all pass.
* chore(eslint): turn on no-unused-vars in src
* chore(eslint): enforce unused-vars rules in src and remove dead code
---------
Co-authored-by: Roomote <[email protected]>
Co-authored-by: Elliott de Launay <[email protected]>1 parent f315cf4 commit 58341d8
223 files changed
Lines changed: 558 additions & 1029 deletions
File tree
- src
- __tests__
- activate
- api
- providers
- __tests__
- fetchers
- __tests__
- transform
- __tests__
- core
- assistant-message
- __tests__
- auto-approval
- checkpoints
- __tests__
- condense
- __tests__
- config
- __tests__
- context-management
- __tests__
- diff/strategies
- environment
- ignore
- mentions
- __tests__
- message-manager
- prompts
- __tests__
- sections
- __tests__
- tools
- __tests__
- native-tools/__tests__
- task-persistence
- task
- __tests__
- tools
- __tests__
- webview
- __tests__
- worktree
- extension
- __tests__
- integrations
- editor/__tests__
- misc
- __tests__
- terminal
- __tests__
- services
- __tests__
- checkpoints
- __tests__
- code-index
- __tests__
- embedders
- __tests__
- processors
- __tests__
- semble/__tests__
- vector-store
- __tests__
- command/__tests__
- glob/__tests__
- marketplace
- mcp
- __tests__
- utils/__tests__
- roo-config
- search
- __tests__
- skills
- __tests__
- tree-sitter
- __tests__
- fixtures
- utils
- __tests__
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1878 | 1878 | | |
1879 | 1879 | | |
1880 | 1880 | | |
1881 | | - | |
1882 | | - | |
| 1881 | + | |
| 1882 | + | |
1883 | 1883 | | |
1884 | 1884 | | |
1885 | 1885 | | |
| |||
1988 | 1988 | | |
1989 | 1989 | | |
1990 | 1990 | | |
1991 | | - | |
1992 | | - | |
| 1991 | + | |
| 1992 | + | |
1993 | 1993 | | |
1994 | 1994 | | |
1995 | 1995 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
272 | 272 | | |
273 | 273 | | |
274 | 274 | | |
275 | | - | |
| 275 | + | |
276 | 276 | | |
277 | 277 | | |
278 | 278 | | |
| |||
284 | 284 | | |
285 | 285 | | |
286 | 286 | | |
287 | | - | |
| 287 | + | |
288 | 288 | | |
289 | 289 | | |
290 | 290 | | |
291 | 291 | | |
292 | 292 | | |
293 | 293 | | |
294 | | - | |
| 294 | + | |
295 | 295 | | |
296 | 296 | | |
297 | 297 | | |
298 | 298 | | |
299 | | - | |
| 299 | + | |
300 | 300 | | |
301 | 301 | | |
302 | 302 | | |
| |||
309 | 309 | | |
310 | 310 | | |
311 | 311 | | |
312 | | - | |
| 312 | + | |
313 | 313 | | |
314 | 314 | | |
315 | 315 | | |
| |||
321 | 321 | | |
322 | 322 | | |
323 | 323 | | |
324 | | - | |
| 324 | + | |
325 | 325 | | |
326 | 326 | | |
327 | 327 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
55 | 55 | | |
56 | 56 | | |
57 | 57 | | |
58 | | - | |
| 58 | + | |
59 | 59 | | |
60 | 60 | | |
61 | 61 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
9 | | - | |
10 | | - | |
11 | | - | |
12 | | - | |
13 | | - | |
14 | | - | |
15 | 9 | | |
16 | 10 | | |
17 | 11 | | |
| |||
686 | 680 | | |
687 | 681 | | |
688 | 682 | | |
689 | | - | |
690 | | - | |
691 | | - | |
692 | | - | |
693 | | - | |
694 | | - | |
695 | | - | |
696 | | - | |
697 | | - | |
698 | | - | |
699 | | - | |
700 | | - | |
701 | 683 | | |
702 | 684 | | |
703 | 685 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
398 | 398 | | |
399 | 399 | | |
400 | 400 | | |
401 | | - | |
| 401 | + | |
402 | 402 | | |
403 | 403 | | |
404 | 404 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
8 | 7 | | |
9 | 8 | | |
10 | 9 | | |
| |||
14 | 13 | | |
15 | 14 | | |
16 | 15 | | |
17 | | - | |
18 | 16 | | |
19 | 17 | | |
20 | 18 | | |
| |||
239 | 237 | | |
240 | 238 | | |
241 | 239 | | |
242 | | - | |
| 240 | + | |
243 | 241 | | |
244 | 242 | | |
245 | 243 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
626 | 626 | | |
627 | 627 | | |
628 | 628 | | |
629 | | - | |
| 629 | + | |
630 | 630 | | |
631 | 631 | | |
632 | 632 | | |
| |||
675 | 675 | | |
676 | 676 | | |
677 | 677 | | |
678 | | - | |
| 678 | + | |
679 | 679 | | |
680 | 680 | | |
681 | 681 | | |
| |||
702 | 702 | | |
703 | 703 | | |
704 | 704 | | |
705 | | - | |
| 705 | + | |
706 | 706 | | |
707 | 707 | | |
708 | 708 | | |
| |||
739 | 739 | | |
740 | 740 | | |
741 | 741 | | |
742 | | - | |
| 742 | + | |
743 | 743 | | |
744 | 744 | | |
745 | 745 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1096 | 1096 | | |
1097 | 1097 | | |
1098 | 1098 | | |
1099 | | - | |
| 1099 | + | |
1100 | 1100 | | |
1101 | 1101 | | |
1102 | 1102 | | |
| |||
1139 | 1139 | | |
1140 | 1140 | | |
1141 | 1141 | | |
1142 | | - | |
| 1142 | + | |
1143 | 1143 | | |
1144 | 1144 | | |
1145 | 1145 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
5 | 4 | | |
6 | 5 | | |
7 | 6 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
328 | 328 | | |
329 | 329 | | |
330 | 330 | | |
331 | | - | |
| 331 | + | |
332 | 332 | | |
333 | 333 | | |
334 | 334 | | |
| |||
0 commit comments