Skip to content

Commit 57d2cc5

Browse files
Merge branch 'main' into fix/issue-1316-openrouter-kimi-k3
2 parents 619915c + 5e8fcc8 commit 57d2cc5

126 files changed

Lines changed: 6812 additions & 1707 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎.coderabbit.yaml‎

Lines changed: 24 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,10 @@ tone_instructions: >-
55
Prioritize correctness, security, data loss, lifecycle, and regressions; avoid speculative style
66
comments and unrelated refactors.
77
8+
knowledge_base:
9+
web_search:
10+
enabled: true
11+
812
reviews:
913
profile: assertive
1014
request_changes_workflow: true
@@ -17,9 +21,11 @@ reviews:
1721
poem: false
1822

1923
auto_review:
20-
enabled: true
24+
enabled: false
2125
drafts: false
2226
auto_incremental_review: true
27+
labels:
28+
- "coderabbit-review-active"
2329

2430
path_filters:
2531
- "!**/node_modules/**"
@@ -34,13 +40,16 @@ reviews:
3440
path_instructions:
3541
- path: "**/*"
3642
instructions: >-
37-
Act as an adversarial second-opinion reviewer. Verify PR claims against implementation,
38-
contracts, and tests. Trace changed inputs through normal, boundary, error, cancellation,
39-
retry, and default paths and their consumers. Seek plausible counterexamples and regressions
40-
from removed safeguards. Report only concrete, actionable findings grounded in changed code
41-
and repository conventions. Prioritize correctness, security, data loss, lifecycle, and test
42-
gaps. Avoid speculative style comments and unrelated refactors. Search for existing helpers
43-
before suggesting abstractions, and distinguish actual defects from unsupported checks.
43+
Act as an adversarial second-opinion reviewer. Verify PR claims against implementation and
44+
contracts. Trace changed inputs through normal, boundary, error, cancellation, retry, and
45+
default paths and their consumers. Seek plausible counterexamples and regressions from removed
46+
safeguards. Identify assumptions in changed code that depend on facts outside the diff. First
47+
verify repository conventions, tests, and related implementations. When a potential finding
48+
depends on external behavior, use web search and prefer official documentation, specifications,
49+
or upstream repositories. Report only concrete, actionable conflicts or failure modes, citing
50+
the relevant repository location or external source. Prioritize correctness, security, data loss,
51+
lifecycle, and test gaps. Do not report generic best practices, unsupported concerns, speculative
52+
style comments, or unrelated refactors. Search for existing helpers before suggesting abstractions.
4453
4554
- path: "**/*.{ts,tsx,js,jsx,mts,mjs,cts,cjs}"
4655
instructions: >-
@@ -56,6 +65,13 @@ reviews:
5665
Check cleanup and deterministic async behavior and prefer shared typed test helpers.
5766
Visible webview changes require a durable Playwright component snapshot; behavior-only
5867
changes do not.
68+
Reject weak assertions on values that could take multiple forms: .toBeDefined() or
69+
.toHaveBeenCalled() alone are not sufficient when the actual type, value, or object
70+
identity is verifiable. For listener registration and removal, assert the same function
71+
reference was added and removed (not expect.any(Function)).
72+
Flag tests that assert in-flight behavior only after the call completes — these cannot
73+
prove the behavior fires during execution. Check that describe block names match the
74+
actual subjects of the tests they contain.
5975
6076
- path: "apps/vscode-e2e/**"
6177
instructions: >-

‎.github/workflows/code-qa.yml‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,8 @@ jobs:
9090
run: pnpm lint
9191
- name: Check types
9292
run: pnpm check-types
93+
- name: Model-check concurrent task lifecycle
94+
run: pnpm lifecycle:model-check
9395

9496
build-vsix:
9597
name: Build test VSIX

0 commit comments

Comments
 (0)