Repository navigation
Commit 57307f6
perf(webview): replace axios in key-info hooks with fetch (#2261)
* perf(webview): replace axios in key-info hooks with fetch
What: useOpenRouterKeyInfo, useRequestyKeyInfo and
useOpenRouterModelProviders now call global fetch instead of axios.get, and
axios is removed from webview-ui/package.json plus the webview importer block
in pnpm-lock.yaml.
Why: these three hooks were the only axios consumers in the webview bundle.
axios shipped ~50 kB of entry-chunk code for three plain GET requests with no
interceptors, no timeout config and no axios-specific error handling anywhere
in the webview. Dropping it removes that weight from every webview load.
Impact: entry chunk 6,183,743 B -> 6,133,127 B (-50,616 B, -0.82%). axios no
longer appears in the entry bundle at all. Behavior is preserved by
construction: characterization tests pin URL, method, headers, response
shaping and the non-2xx throw decision, and the same 19 assertions pass
unchanged against both the axios and the fetch implementation.
src/ keeps its axios dependency; 14 production files there still import it.
* lint(webview): forbid re-importing axios in webview sources
What: webview-ui/eslint.config.mjs gains a no-restricted-imports block scoped
to src/**/*.{ts,tsx} that rejects `axios` with a message explaining the scoped
dependency drop.
Why: axios was removed from webview-ui/package.json, but pnpm's hoisted store
still resolves it, so a new `import axios from "axios"` would silently
reintroduce the dependency instead of failing loudly. The guard turns the
"axios removed" claim from incidental into enforced.
Impact: no runtime change. A webview file importing axios now fails lint with
exit 1. src/ is unaffected and keeps its axios dependency.
* test(webview): pin the unparseable-2xx-body path in the key-info hooks
What: one new case per hook covering a 2xx response whose body is not valid
JSON, so response.json() rejects inside the try block. Each asserts the same
log call and fallback value as the existing blanket-catch cases.
Why: the fetch swap moved body parsing inside the try, so a malformed 2xx body
now flows through the catch instead of axios' parse step. That path was
uncovered. The transport seam gained an optional jsonRejects field so json()
can reject while ok stays true.
Impact: no production change. Verified fail-on-shape: with the hook's catch
changed to rethrow, the new case fails at isSuccess, so it pins the swallow
rather than merely exercising the line.
* test(webview): assert the diagnostic in key-info hook error matchers
What: the non-2xx cases now match the logged Error's message exactly
("Request failed with status code 401/403/500") instead of expect.anything().
The schema-validation cases now match the logged ZodError's issues array and a
real issue path instead of expect.anything().
Why: expect.anything() accepts any value, including an Error with an empty
message, so a regression that dropped the HTTP status from the thrown message
would still pass. The same looseness applied to the validation-failure logs,
which is the adjacent instance of the pattern.
Impact: no production change. Verified the tightened matchers bite by
temporarily degrading each hook (message without status, validation log
replaced by a generic Error): in both cases exactly the targeted test fails.
* test(webview): strengthen fetch hook coverage and lint guardrails
---------
Co-authored-by: Elliott de Launay <[email protected]>1 parent c6d5360 commit 57307f6
10 files changed
Lines changed: 479 additions & 30 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
43 | 60 | | |
44 | 61 | | |
45 | 62 | | |
| |||
63 | 80 | | |
64 | 81 | | |
65 | 82 | | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
66 | 88 | | |
67 | 89 | | |
68 | 90 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
41 | | - | |
42 | 41 | | |
43 | 42 | | |
44 | 43 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
2 | | - | |
3 | | - | |
4 | 1 | | |
5 | | - | |
| 2 | + | |
| 3 | + | |
6 | 4 | | |
7 | | - | |
| 5 | + | |
8 | 6 | | |
9 | 7 | | |
10 | 8 | | |
11 | | - | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
12 | 37 | | |
13 | 38 | | |
14 | 39 | | |
| |||
19 | 44 | | |
20 | 45 | | |
21 | 46 | | |
22 | | - | |
23 | | - | |
24 | | - | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
25 | 153 | | |
26 | 154 | | |
27 | 155 | | |
28 | 156 | | |
29 | 157 | | |
30 | 158 | | |
31 | | - | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
32 | 163 | | |
33 | 164 | | |
34 | | - | |
| 165 | + | |
35 | 166 | | |
36 | | - | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
37 | 170 | | |
38 | 171 | | |
39 | 172 | | |
| |||
42 | 175 | | |
43 | 176 | | |
44 | 177 | | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
45 | 190 | | |
0 commit comments