Repository navigation
Commit 5163cd3
committed
fix(webview): localize the profile-deletion warning and pin real ordering in two tests
The deletion-activation warning took its text from the error class, so it stayed English for
every locale; it now goes through common:warnings.profile_deleted_activation_failed with the
replacement profile name interpolated, and the key is present in all 18 locale bundles. The
bundle wording differs from the class message on purpose: the class message stays in the log
line, and an assertion that expected it verbatim would also pass for a handler that never asked
i18n. locale-bundles.spec.ts now pins the added warning key next to the added error key.
Two ordering assertions compared things that cannot differ. The rename rollback compared an
index into deleteConfig.mock.calls with an index into saveConfig.mock.calls, which is 1 > 0 in
every run whatever the real order is; it now compares the two mocks' shared invocation clock,
which reddens when the restore is moved before the delete. The overlapping-write cases parked
both rejections at once, so both handlers ran in creation order and the B-settles-first case
never exercised B-before-A; the memento double now parks each update until the test rejects it,
so the case picks the handler order, and the older write leaving the cache alone is what keeps
both cases on the persisted value.
Gates: tsc --noEmit exit 0; eslint --max-warnings=0 --no-warn-ignored exit 0 on every touched
file; prettier --check exit 0 (locales included); ContextProxy.globalStateRestore.spec.ts 5
passed, webviewMessageHandler.spec.ts 187 passed, locale-bundles.spec.ts 18 passed;
src/eslint-suppressions.json untouched. Controls measured before landing: the invocation-clock
assertion goes 1 failed with the restore moved ahead of the delete, the class-message handler
goes 1 failed against the key-based expectation, and the generation-map restore goes 1 failed
(A rejects first) while B rejects first stays green. No .changeset, no CHANGELOG edit.1 parent 5cbdcf1 commit 5163cd3
22 files changed
Lines changed: 94 additions & 33 deletions
File tree
- src
- core
- config/__tests__
- webview
- __tests__
- i18n
- __tests__
- locales
- ca
- de
- en
- es
- fr
- hi
- id
- it
- ja
- ko
- nl
- pl
- pt-BR
- ru
- tr
- vi
- zh-CN
- zh-TW
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
25 | | - | |
| 25 | + | |
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
29 | 33 | | |
30 | 34 | | |
31 | 35 | | |
| |||
40 | 44 | | |
41 | 45 | | |
42 | 46 | | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
43 | 52 | | |
44 | 53 | | |
45 | 54 | | |
| |||
74 | 83 | | |
75 | 84 | | |
76 | 85 | | |
77 | | - | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
78 | 92 | | |
79 | 93 | | |
80 | 94 | | |
| |||
83 | 97 | | |
84 | 98 | | |
85 | 99 | | |
86 | | - | |
| 100 | + | |
87 | 101 | | |
88 | 102 | | |
89 | | - | |
| 103 | + | |
90 | 104 | | |
91 | | - | |
92 | 105 | | |
93 | 106 | | |
94 | 107 | | |
95 | 108 | | |
96 | | - | |
97 | | - | |
98 | | - | |
99 | | - | |
100 | | - | |
101 | | - | |
102 | | - | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
103 | 121 | | |
104 | | - | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
105 | 126 | | |
106 | 127 | | |
107 | | - | |
108 | | - | |
109 | | - | |
110 | | - | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
111 | 135 | | |
112 | 136 | | |
113 | 137 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2346 | 2346 | | |
2347 | 2347 | | |
2348 | 2348 | | |
2349 | | - | |
| 2349 | + | |
| 2350 | + | |
| 2351 | + | |
| 2352 | + | |
| 2353 | + | |
2350 | 2354 | | |
2351 | | - | |
| 2355 | + | |
2352 | 2356 | | |
2353 | 2357 | | |
2354 | 2358 | | |
| |||
3176 | 3180 | | |
3177 | 3181 | | |
3178 | 3182 | | |
3179 | | - | |
3180 | | - | |
3181 | | - | |
3182 | | - | |
3183 | | - | |
3184 | | - | |
3185 | | - | |
3186 | | - | |
3187 | | - | |
3188 | | - | |
| 3183 | + | |
| 3184 | + | |
| 3185 | + | |
| 3186 | + | |
| 3187 | + | |
| 3188 | + | |
| 3189 | + | |
| 3190 | + | |
| 3191 | + | |
| 3192 | + | |
| 3193 | + | |
| 3194 | + | |
| 3195 | + | |
| 3196 | + | |
3189 | 3197 | | |
3190 | 3198 | | |
3191 | 3199 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2849 | 2849 | | |
2850 | 2850 | | |
2851 | 2851 | | |
2852 | | - | |
| 2852 | + | |
| 2853 | + | |
| 2854 | + | |
| 2855 | + | |
| 2856 | + | |
2853 | 2857 | | |
2854 | 2858 | | |
2855 | 2859 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
29 | | - | |
| 29 | + | |
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
| |||
49 | 49 | | |
50 | 50 | | |
51 | 51 | | |
52 | | - | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
53 | 57 | | |
54 | 58 | | |
55 | 59 | | |
56 | | - | |
| 60 | + | |
57 | 61 | | |
58 | 62 | | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
59 | 66 | | |
60 | 67 | | |
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
123 | 123 | | |
124 | 124 | | |
125 | 125 | | |
| 126 | + | |
126 | 127 | | |
127 | 128 | | |
128 | 129 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
0 commit comments