Repository navigation
Commit 4d2365d
committed
test(checkpoints): stop the checkpoint suite from outrunning its hook budget on Windows
platform-unit-test (windows-latest) failed test:services with 5 failures in
ShadowCheckpointService.spec.ts, every one of them a hook timeout in the shared beforeEach.
One setup there spawns about 14 git subprocesses (workspace repo init plus shadow repo init),
and the ~40 tests that share those hooks never released the repositories they created, so the
shared temp dir carried one git repository pair per test until the afterAll. vitest.config.ts
gives this lane two workers only on Windows CI, and every repository that is still on disk is
extra cost on every spawn, which is what pushed the hook past the 20s hookTimeout there and
nowhere else.
Release each test's pair in the afterEach, the way the standalone tests in this file already
release their own scratch repos, and give the setup and cleanup hooks the same 60s allowance
the afterAll cleanup already carries. Nothing was skipped and no suppression was added.
Two tests pin the release: a marker written into the repository the hooks created has to be
gone before the next test runs. With the two rmScratch calls commented out the suite reports
1 failed | 43 passed (44) and the failure reads
"AssertionError: expected true to be false // Object.is equality.
With them restored the suite reports 44 passed.1 parent 3535359 commit 4d2365d
1 file changed
Lines changed: 41 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
41 | 41 | | |
42 | 42 | | |
43 | 43 | | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
44 | 53 | | |
45 | 54 | | |
46 | 55 | | |
| |||
83 | 92 | | |
84 | 93 | | |
85 | 94 | | |
| 95 | + | |
| 96 | + | |
86 | 97 | | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
87 | 102 | | |
88 | | - | |
89 | | - | |
| 103 | + | |
| 104 | + | |
90 | 105 | | |
91 | 106 | | |
92 | 107 | | |
93 | 108 | | |
94 | 109 | | |
95 | 110 | | |
96 | 111 | | |
97 | | - | |
| 112 | + | |
98 | 113 | | |
99 | 114 | | |
100 | 115 | | |
101 | | - | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
102 | 123 | | |
103 | 124 | | |
104 | 125 | | |
| |||
1166 | 1187 | | |
1167 | 1188 | | |
1168 | 1189 | | |
| 1190 | + | |
| 1191 | + | |
| 1192 | + | |
| 1193 | + | |
| 1194 | + | |
| 1195 | + | |
| 1196 | + | |
| 1197 | + | |
| 1198 | + | |
| 1199 | + | |
| 1200 | + | |
| 1201 | + | |
| 1202 | + | |
| 1203 | + | |
| 1204 | + | |
| 1205 | + | |
1169 | 1206 | | |
1170 | 1207 | | |
1171 | 1208 | | |
| |||
0 commit comments