Repository navigation
Commit 4d002c4
committed
test(config,webview): cover storage failures and the sibling view's settings on profile deletion
Round 2 of the #1919 review (head c2206c5), tests only.
- ProviderSettingsManager.spec: a storage read failure now has a named contract in both
methods deleteProviderProfile() branches on. deleteConfig() and getProfile() rethrow a
storage outage wrapped ("Failed to delete config: ...", "Failed to get profile: ...")
instead of typing it as ProviderSettingsNotFoundError, so an outage cannot be mistaken
for a missing profile and cannot prune a list entry whose record is still stored.
- ClineProvider.sticky-profile.spec: the mid-deletion case gains the cross-view half it
was missing. A second view, sharing the acting view's ContextProxy the way production
builds the tab view (activate/registerCommands.ts:449), activates the survivor while the
record delete is in flight; the deletion must follow that choice and leave the shared
provider keys carrying that survivor's settings rather than its own entry-time pick.
Both measure green against c2206c5: nothing is laundered and nothing is stale today, so
this round adds coverage rather than changing behaviour. Each assertion was shown to
redden under the regression it guards (typing the outage as not-found in either method,
dropping the activation's settings write, or pushing the entry-time survivor's settings
over the sibling's activation), each on its own.1 parent c2206c5 commit 4d002c4
2 files changed
Lines changed: 121 additions & 0 deletions
File tree
- src/core
- config/__tests__
- webview/__tests__
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
983 | 983 | | |
984 | 984 | | |
985 | 985 | | |
| 986 | + | |
| 987 | + | |
| 988 | + | |
| 989 | + | |
| 990 | + | |
| 991 | + | |
| 992 | + | |
| 993 | + | |
| 994 | + | |
| 995 | + | |
| 996 | + | |
| 997 | + | |
| 998 | + | |
| 999 | + | |
986 | 1000 | | |
987 | 1001 | | |
988 | 1002 | | |
| |||
1122 | 1136 | | |
1123 | 1137 | | |
1124 | 1138 | | |
| 1139 | + | |
| 1140 | + | |
| 1141 | + | |
| 1142 | + | |
| 1143 | + | |
| 1144 | + | |
| 1145 | + | |
| 1146 | + | |
| 1147 | + | |
| 1148 | + | |
| 1149 | + | |
| 1150 | + | |
| 1151 | + | |
| 1152 | + | |
1125 | 1153 | | |
1126 | 1154 | | |
1127 | 1155 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1342 | 1342 | | |
1343 | 1343 | | |
1344 | 1344 | | |
| 1345 | + | |
| 1346 | + | |
| 1347 | + | |
| 1348 | + | |
| 1349 | + | |
| 1350 | + | |
| 1351 | + | |
| 1352 | + | |
| 1353 | + | |
| 1354 | + | |
| 1355 | + | |
| 1356 | + | |
| 1357 | + | |
| 1358 | + | |
| 1359 | + | |
| 1360 | + | |
| 1361 | + | |
| 1362 | + | |
| 1363 | + | |
| 1364 | + | |
| 1365 | + | |
| 1366 | + | |
| 1367 | + | |
| 1368 | + | |
| 1369 | + | |
| 1370 | + | |
| 1371 | + | |
| 1372 | + | |
| 1373 | + | |
| 1374 | + | |
| 1375 | + | |
| 1376 | + | |
| 1377 | + | |
| 1378 | + | |
| 1379 | + | |
| 1380 | + | |
| 1381 | + | |
| 1382 | + | |
| 1383 | + | |
| 1384 | + | |
| 1385 | + | |
| 1386 | + | |
| 1387 | + | |
| 1388 | + | |
| 1389 | + | |
| 1390 | + | |
| 1391 | + | |
| 1392 | + | |
| 1393 | + | |
| 1394 | + | |
| 1395 | + | |
| 1396 | + | |
| 1397 | + | |
| 1398 | + | |
| 1399 | + | |
| 1400 | + | |
| 1401 | + | |
| 1402 | + | |
| 1403 | + | |
| 1404 | + | |
| 1405 | + | |
| 1406 | + | |
| 1407 | + | |
| 1408 | + | |
| 1409 | + | |
| 1410 | + | |
| 1411 | + | |
| 1412 | + | |
| 1413 | + | |
| 1414 | + | |
| 1415 | + | |
| 1416 | + | |
| 1417 | + | |
| 1418 | + | |
| 1419 | + | |
| 1420 | + | |
| 1421 | + | |
| 1422 | + | |
| 1423 | + | |
| 1424 | + | |
| 1425 | + | |
| 1426 | + | |
| 1427 | + | |
| 1428 | + | |
| 1429 | + | |
| 1430 | + | |
| 1431 | + | |
| 1432 | + | |
| 1433 | + | |
| 1434 | + | |
| 1435 | + | |
| 1436 | + | |
| 1437 | + | |
1345 | 1438 | | |
1346 | 1439 | | |
0 commit comments