Skip to content

Commit 3b825bf

Browse files
zoomote2[bot]roomote
zoomote2[bot]
and
roomote
authored
[Fix] Five webview visual tests fail on every pull request (#2209)
* test(webview): refresh stale toolkit baselines missed by #2163 Regenerate the five baselines that #2163 left on the mocked toolkit rendering: history-rename-editor in all four themes and opencode-go-temperature. Captured by the pinned mcr.microsoft.com/playwright:v1.62.1-noble container via the Visual Regression workflow on this branch. The real toolkit places the search field's icon inline inside the field and renders the custom-temperature checkbox inline with its label (480x359 -> 480x340), matching the intended appearance from #2163. Fixes #2206 * ci(webview): drop pull_request path filter from Visual Regression The Protect Main ruleset should require the webview-visual check. GitHub keeps path-filtered workflows in a pending state on pull requests that do not match the filter, so a required check would block those PRs from merging. Remove the pull_request paths filter so webview-visual, theme-fixtures, and extension-host-visual report on every pull request, like code-qa and e2e already do. The merge_group event ignores path filters, so merge-queue runs are unchanged. --------- Co-authored-by: Roomote <[email protected]>
1 parent 764db84 commit 3b825bf

6 files changed

Lines changed: 4 additions & 15 deletions

File tree

‎.github/workflows/visual-regression.yml‎

Lines changed: 4 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -2,23 +2,12 @@ name: Visual Regression
22

33
on:
44
workflow_dispatch:
5+
# No `paths` filter: this workflow backs the required `webview-visual`
6+
# check. GitHub keeps path-filtered workflows "pending" on pull requests
7+
# that do not match the filter, which blocks merging for a required check.
8+
# The merge_group event ignores path filters, so the queue is unaffected.
59
pull_request:
610
types: [opened, reopened, ready_for_review, synchronize]
7-
paths:
8-
- "apps/vscode-e2e/package.json"
9-
- "apps/vscode-e2e/src/theme-fixtures/**"
10-
- "apps/vscode-e2e/src/visual/**"
11-
- "apps/vscode-e2e/playwright-electron.config.ts"
12-
- "packages/types/src/api.ts"
13-
- "packages/types/src/vscode-extension-host.ts"
14-
- "src/core/webview/ClineProvider.ts"
15-
- "src/core/webview/webviewMessageHandler.ts"
16-
- "src/extension/api.ts"
17-
- "webview-ui/**"
18-
- "src/shared/**"
19-
- "package.json"
20-
- "pnpm-lock.yaml"
21-
- ".github/workflows/visual-regression.yml"
2211
merge_group:
2312
types: [checks_requested]
2413

‎webview-ui/src/components/history/__tests__/__screenshots__/history-rename-editor-dark.png‎

-247 Bytes
Loading

‎webview-ui/src/components/history/__tests__/__screenshots__/history-rename-editor-high-contrast-light.png‎

-312 Bytes
Loading

‎webview-ui/src/components/history/__tests__/__screenshots__/history-rename-editor-high-contrast.png‎

-374 Bytes
Loading

‎webview-ui/src/components/history/__tests__/__screenshots__/history-rename-editor-light.png‎

-350 Bytes
Loading

‎webview-ui/src/components/settings/__tests__/__screenshots__/opencode-go-temperature.png‎

610 Bytes
Loading

0 commit comments

Comments
 (0)