@@ -3,6 +3,8 @@ import { makeExtensionContext } from "../../../test-utils/vscode"
33import { CodeIndexManager } from "../manager"
44import { CodeIndexManagerRegistry } from "../code-index-manager-registry"
55import { CodeIndexServiceFactory } from "../service-factory"
6+ import { CodeIndexOrchestrator } from "../orchestrator"
7+ import { CodeIndexSearchService } from "../search-service"
68import type { MockedClass } from "vitest"
79import * as path from "path"
810import { providerIdentifiers } from "@roo-code/types/provider-identifiers"
@@ -474,63 +476,19 @@ describe("CodeIndexManager - handleSettingsChange regression", () => {
474476 ; ( manager as any ) . _configManager = mockConfigManager
475477 } )
476478
477- it ( "should validate embedder during _recreateServices when validation succeeds" , async ( ) => {
478- // Arrange
479- mockServiceFactoryInstance . validateEmbedder . mockResolvedValue ( { valid : true } )
480-
481- // Act - directly call the private method for testing
482- await ( manager as any ) . _recreateServices ( )
483-
484- // Assert
485- expect ( mockServiceFactoryInstance . createServices ) . toHaveBeenCalled ( )
486- const createdEmbedder = mockServiceFactoryInstance . createServices . mock . results [ 0 ] . value . embedder
487- expect ( mockServiceFactoryInstance . validateEmbedder ) . toHaveBeenCalledWith ( createdEmbedder )
488- expect ( mockStateManager . setSystemState ) . not . toHaveBeenCalledWith ( "Error" , expect . any ( String ) )
489- } )
490-
491- it ( "should set error state when embedder validation fails" , async ( ) => {
492- // Arrange
479+ it ( "should create indexing services without a startup embedder validation request" , async ( ) => {
493480 mockServiceFactoryInstance . validateEmbedder . mockResolvedValue ( {
494481 valid : false ,
495- error : "embeddings:validation.authenticationFailed " ,
482+ error : "Embedder unavailable " ,
496483 } )
497484
498- // Act & Assert
499- await expect ( ( manager as any ) . _recreateServices ( ) ) . rejects . toThrow (
500- "embeddings:validation.authenticationFailed" ,
501- )
485+ await manager [ "_recreateServices" ] ( )
502486
503- // Assert other expectations
504487 expect ( mockServiceFactoryInstance . createServices ) . toHaveBeenCalled ( )
505- const createdEmbedder = mockServiceFactoryInstance . createServices . mock . results [ 0 ] . value . embedder
506- expect ( mockServiceFactoryInstance . validateEmbedder ) . toHaveBeenCalledWith ( createdEmbedder )
507- expect ( mockStateManager . setSystemState ) . toHaveBeenCalledWith (
508- "Error" ,
509- "embeddings:validation.authenticationFailed" ,
510- )
511- } )
512-
513- it ( "should set generic error state when embedder validation throws" , async ( ) => {
514- // Arrange
515- // Since the real service factory catches exceptions, we should mock it to resolve with an error
516- mockServiceFactoryInstance . validateEmbedder . mockResolvedValue ( {
517- valid : false ,
518- error : "embeddings:validation.configurationError" ,
519- } )
520-
521- // Act & Assert
522- await expect ( ( manager as any ) . _recreateServices ( ) ) . rejects . toThrow (
523- "embeddings:validation.configurationError" ,
524- )
525-
526- // Assert other expectations
527- expect ( mockServiceFactoryInstance . createServices ) . toHaveBeenCalled ( )
528- const createdEmbedder = mockServiceFactoryInstance . createServices . mock . results [ 0 ] . value . embedder
529- expect ( mockServiceFactoryInstance . validateEmbedder ) . toHaveBeenCalledWith ( createdEmbedder )
530- expect ( mockStateManager . setSystemState ) . toHaveBeenCalledWith (
531- "Error" ,
532- "embeddings:validation.configurationError" ,
533- )
488+ expect ( mockServiceFactoryInstance . validateEmbedder ) . not . toHaveBeenCalled ( )
489+ expect ( mockStateManager . setSystemState ) . not . toHaveBeenCalledWith ( "Error" , expect . any ( String ) )
490+ expect ( manager [ "_orchestrator" ] ) . toBeInstanceOf ( CodeIndexOrchestrator )
491+ expect ( manager [ "_searchService" ] ) . toBeInstanceOf ( CodeIndexSearchService )
534492 } )
535493
536494 it ( "should handle embedder creation failure" , async ( ) => {
@@ -684,7 +642,7 @@ describe("CodeIndexManager - handleSettingsChange regression", () => {
684642 // Assert - manager should be initialized again
685643 expect ( manager . isInitialized ) . toBe ( true )
686644 expect ( mockServiceFactoryInstance . createServices ) . toHaveBeenCalled ( )
687- expect ( mockServiceFactoryInstance . validateEmbedder ) . toHaveBeenCalled ( )
645+ expect ( mockServiceFactoryInstance . validateEmbedder ) . not . toHaveBeenCalled ( )
688646 } )
689647
690648 it ( "should be safe to call when not in error state (idempotent)" , async ( ) => {
0 commit comments