Skip to content

Commit 381750e

Browse files
committed
test(task): cover isolated same-mode rejection
1 parent a1c98d8 commit 381750e

6 files changed

Lines changed: 3 additions & 8 deletions

‎src/core/assistant-message/__tests__/presentAssistantMessage-custom-tool.spec.ts‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,6 @@ describe("presentAssistantMessage - Custom Tool Recording", () => {
7878
}),
7979
}),
8080
},
81-
getTaskMode: vi.fn().mockResolvedValue("code"),
8281
say: vi.fn().mockResolvedValue(undefined),
8382
ask: vi.fn().mockResolvedValue({ response: "yesButtonClicked" }),
8483
}

‎src/core/assistant-message/__tests__/presentAssistantMessage-images.spec.ts‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,6 @@ describe("presentAssistantMessage - Image Handling in Native Tool Calling", () =
5858
}),
5959
}),
6060
},
61-
getTaskMode: vi.fn().mockResolvedValue("code"),
6261
say: vi.fn().mockResolvedValue(undefined),
6362
ask: vi.fn().mockResolvedValue({ response: "yesButtonClicked" }),
6463
}

‎src/core/assistant-message/__tests__/presentAssistantMessage-tool-usage-attribution.spec.ts‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,6 @@ interface MockTask {
7676
say: ReturnType<typeof vi.fn>
7777
ask: ReturnType<typeof vi.fn>
7878
pushToolResultToUserContent: ReturnType<typeof vi.fn>
79-
getTaskMode: ReturnType<typeof vi.fn>
8079
}
8180

8281
describe("presentAssistantMessage - tool usage attribution", () => {
@@ -120,7 +119,6 @@ describe("presentAssistantMessage - tool usage attribution", () => {
120119
say: vi.fn().mockResolvedValue(undefined),
121120
ask: vi.fn().mockResolvedValue({ response: "yesButtonClicked" }),
122121
pushToolResultToUserContent: vi.fn(),
123-
getTaskMode: vi.fn().mockResolvedValue("code"),
124122
}
125123

126124
mockTask.pushToolResultToUserContent = vi

‎src/core/assistant-message/__tests__/presentAssistantMessage-unknown-tool.spec.ts‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,6 @@ describe("presentAssistantMessage - Unknown Tool Handling", () => {
6161
}),
6262
}),
6363
},
64-
getTaskMode: vi.fn().mockResolvedValue("code"),
6564
say: vi.fn().mockResolvedValue(undefined),
6665
ask: vi.fn().mockResolvedValue({ response: "yesButtonClicked" }),
6766
}

‎src/core/environment/__tests__/getEnvironmentDetails.spec.ts‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,6 @@ describe("getEnvironmentDetails", () => {
118118
deref: vi.fn().mockReturnValue(mockProvider),
119119
[Symbol.toStringTag]: "WeakRef",
120120
} as unknown as WeakRef<ClineProvider>,
121-
getTaskMode: vi.fn().mockResolvedValue("code"),
122121
}
123122

124123
// Mock other dependencies.

‎src/core/tools/__tests__/switchModeTool.spec.ts‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -116,15 +116,16 @@ describe("SwitchModeTool", () => {
116116

117117
// ===== Already in mode tests =====
118118

119-
it("should handle switching to the same mode", async () => {
120-
// Current mode is "code" (from mockGetState)
119+
it("should reject switching to the task's current mode when provider state differs", async () => {
120+
mockGetState.mockResolvedValue({ mode: "orchestrator", customModes: [] })
121121
const block = createBlock({ mode_slug: "code", reason: "already here" })
122122

123123
await switchModeTool.handle(mockTask, block, mockCallbacks)
124124

125125
expect(mockTask.recordToolError).toHaveBeenCalledWith("switch_mode")
126126
expect(mockTask.didToolFailInCurrentTurn).toBe(true)
127127
expect(mockCallbacks.pushToolResult).toHaveBeenCalledWith("Already in Code mode.")
128+
expect(mockTask.getTaskMode).toHaveBeenCalledOnce()
128129
// Should NOT ask approval or switch
129130
expect(mockCallbacks.askApproval).not.toHaveBeenCalled()
130131
expect(mockHandleModeSwitch).not.toHaveBeenCalled()

0 commit comments

Comments
 (0)