Skip to content

Commit 36ec2e6

Browse files
author
Bertan Ari
committed
refactor(subtask-links): drop redundant message type checks and keep taskMessages mock complete
1 parent d8393bf commit 36ec2e6

3 files changed

Lines changed: 4 additions & 9 deletions

File tree

‎src/__tests__/ClineProvider.subtask-links.spec.ts‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
import { beforeEach, describe, expect, it, vi } from "vitest"
22
import { clineMessageSchema, type ClineMessage, type HistoryItem } from "@roo-code/types"
33

4-
vi.mock("../core/task-persistence/taskMessages", () => ({
4+
vi.mock("../core/task-persistence/taskMessages", async (importOriginal) => ({
5+
...(await importOriginal<typeof import("../core/task-persistence/taskMessages")>()),
56
readTaskMessages: vi.fn(),
67
}))
78
vi.mock("../core/task-persistence", async (importOriginal) => ({

‎src/core/webview/ClineProvider.ts‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4265,8 +4265,7 @@ export class ClineProvider
42654265
const parentMessages = await readTaskMessages({ taskId: parentTaskId, globalStoragePath })
42664266
for (let messageIndex = parentMessages.length - 1; messageIndex >= 0; messageIndex--) {
42674267
const candidate = parentMessages[messageIndex]
4268-
// Stryker disable next-line ConditionalExpression: equivalent mutant, only ask messages carry an ask field, so the ask check alone rejects say rows
4269-
if (candidate.type !== "ask" || candidate.ask !== "tool" || !candidate.text) continue
4268+
if (candidate.ask !== "tool" || !candidate.text) continue
42704269

42714270
let tool: { tool?: unknown; content?: unknown } | null
42724271
try {

‎webview-ui/src/components/chat/ChatRow.tsx‎

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -113,12 +113,7 @@ function getPreviousTodos(messages: ClineMessage[], currentMessageTs: number): a
113113
}
114114

115115
function isNewTaskMessage(message: ClineMessage): boolean {
116-
return (
117-
// Stryker disable next-line ConditionalExpression: equivalent mutant, only ask messages carry an ask field, so the ask check alone rejects say rows
118-
message.type === "ask" &&
119-
message.ask === "tool" &&
120-
safeJsonParse<ClineSayTool>(message.text)?.tool === "newTask"
121-
)
116+
return message.ask === "tool" && safeJsonParse<ClineSayTool>(message.text)?.tool === "newTask"
122117
}
123118

124119
function getLinkedChildTaskId(

0 commit comments

Comments
 (0)