@@ -1255,11 +1255,16 @@ describe("ClineProvider", () => {
12551255 expect ( assignHtml ) . toHaveBeenCalledTimes ( 3 )
12561256 // One mount heartbeat is insufficient: a new healthy window must
12571257 // span a full minute of periodic heartbeats before replenishing.
1258+ const attempts = provider [ "webviewRecoveryAttempts" ]
1259+ expect ( attempts ) . toBe ( 3 )
12581260 provider . updateWebviewHeartbeat ( )
1261+ expect ( provider [ "webviewRecoveryAttempts" ] ) . toBe ( attempts )
12591262 await vi . advanceTimersByTimeAsync ( 30_000 )
12601263 provider . updateWebviewHeartbeat ( )
1264+ expect ( provider [ "webviewRecoveryAttempts" ] ) . toBe ( attempts )
12611265 await vi . advanceTimersByTimeAsync ( 30_000 )
12621266 provider . updateWebviewHeartbeat ( )
1267+ expect ( provider [ "webviewRecoveryAttempts" ] ) . toBe ( 0 )
12631268 await vi . advanceTimersByTimeAsync ( 120_000 )
12641269 expect ( assignHtml ) . toHaveBeenCalledTimes ( 4 )
12651270 } )
@@ -1404,6 +1409,44 @@ describe("ClineProvider", () => {
14041409 expect ( vscode . commands . executeCommand ) . not . toHaveBeenCalledWith ( "workbench.action.reloadWindow" )
14051410 } )
14061411
1412+ test ( "keeps the Reload Window action available after visibility grace resets" , async ( ) => {
1413+ await provider . resolveWebviewView ( mockWebviewView )
1414+ vi . mocked ( vscode . commands . getCommands ) . mockResolvedValue ( [ ] )
1415+ let choose : ( value : string ) => void = ( ) => {
1416+ throw new Error ( "Notification not shown" )
1417+ }
1418+ const choice = new Promise < string > ( ( resolve ) => {
1419+ choose = resolve
1420+ } )
1421+ vi . mocked ( vscode . window . showWarningMessage ) . mockImplementation ( vi . fn ( ) . mockReturnValue ( choice ) )
1422+ await vi . advanceTimersByTimeAsync ( 130_000 )
1423+
1424+ visibilityCallback ( )
1425+ choose ( "Reload Window" )
1426+ await vi . advanceTimersByTimeAsync ( 0 )
1427+
1428+ expect ( vscode . commands . executeCommand ) . toHaveBeenCalledWith ( "workbench.action.reloadWindow" )
1429+ } )
1430+
1431+ test ( "waits for the final HTML attempt to settle before reporting the limit" , async ( ) => {
1432+ await provider . resolveWebviewView ( mockWebviewView )
1433+ provider [ "webviewRecoveryAttempts" ] = 2
1434+ let rejectHtml : ( error : Error ) => void = ( ) => {
1435+ throw new Error ( "HTML not requested" )
1436+ }
1437+ const html = new Promise < string > ( ( _resolve , reject ) => {
1438+ rejectHtml = reject
1439+ } )
1440+ provider [ "getWebviewHtml" ] = vi . fn < ( webview : vscode . Webview ) => Promise < string > > ( ) . mockReturnValue ( html )
1441+ await vi . advanceTimersByTimeAsync ( 240_000 )
1442+ expect ( provider [ "webviewRecoveryAttempts" ] ) . toBe ( 3 )
1443+ expect ( vscode . window . showWarningMessage ) . not . toHaveBeenCalled ( )
1444+
1445+ rejectHtml ( new Error ( "cannot generate" ) )
1446+ await vi . advanceTimersByTimeAsync ( 60_000 )
1447+ expect ( vscode . window . showWarningMessage ) . toHaveBeenCalledTimes ( 1 )
1448+ } )
1449+
14071450 test ( "bounds failed HTML generation and reports the exhausted budget once" , async ( ) => {
14081451 await provider . resolveWebviewView ( mockWebviewView )
14091452 const generate = vi . spyOn ( provider , "getState" ) . mockRejectedValue ( new Error ( "cannot generate" ) )
@@ -2068,6 +2111,30 @@ describe("ClineProvider", () => {
20682111 } as unknown as vscode . WebviewPanel
20692112 } )
20702113
2114+ test ( "disposes the current tab provider and its watchdog registration" , async ( ) => {
2115+ const onDispose : Array < ( ) => unknown > = [ ]
2116+ const registration = { dispose : vi . fn ( ) }
2117+ vi . mocked ( mockWebviewPanel . onDidDispose ) . mockImplementation ( ( listener , _thisArg , disposables ) => {
2118+ onDispose . push ( listener )
2119+ const disposable = onDispose . length === 1 ? registration : { dispose : vi . fn ( ) }
2120+ disposables ?. push ( disposable )
2121+ return disposable
2122+ } )
2123+ await provider . resolveWebviewView ( mockWebviewPanel )
2124+ expect ( provider [ "webviewWatchdogInterval" ] ) . not . toBeNull ( )
2125+ const dispose = vi . spyOn ( provider , "dispose" )
2126+ const html = mockWebviewPanel . webview . html
2127+
2128+ await onDispose [ 0 ] ( )
2129+
2130+ expect ( dispose ) . toHaveBeenCalledTimes ( 1 )
2131+ expect ( provider [ "_disposed" ] ) . toBe ( true )
2132+ expect ( provider [ "webviewWatchdogInterval" ] ) . toBeNull ( )
2133+ expect ( registration . dispose ) . toHaveBeenCalledTimes ( 1 )
2134+ await vi . advanceTimersByTimeAsync ( 600_000 )
2135+ expect ( mockWebviewPanel . webview . html ) . toBe ( html )
2136+ } )
2137+
20712138 test . each ( [ false , true ] ) (
20722139 "replaces the tab host without disposing its provider or task (interrupted: %s)" ,
20732140 async ( interrupted ) => {
0 commit comments