Repository navigation
Commit 35ef0a6
committed
fix(terminal): harden abort guard, add WSL UNC path conversion, and improve test coverage (#321)
- Guard sendText("\x03") inside aborting gate in TerminalProcess.ts to
prevent overlapping retry loops when abort() is called repeatedly
- Add 3-tier WSL path conversion and execaShellPath override in
ExecaTerminalProcess.ts (drive-letter → WSL UNC strip → wslpath
fallback), with POSIX early-return guard to avoid unnecessary
wslpath call for already-POSIX paths
- Add 14 tests for Terminal constructor and streamAvailable timeout
test in Terminal.spec.ts / TerminalProcess.spec.ts; add 4 tests for
WSL UNC path conversion and execaShellPath override in
ExecaTerminalProcess.spec.ts; extract console.error spy to
describe-level beforeEach/afterEach in TerminalProcess.spec.ts1 parent b871106 commit 35ef0a6
5 files changed
Lines changed: 504 additions & 37 deletions
File tree
- src/integrations/terminal
- __tests__
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
10 | 52 | | |
11 | 53 | | |
12 | 54 | | |
| |||
40 | 82 | | |
41 | 83 | | |
42 | 84 | | |
43 | | - | |
44 | | - | |
| 85 | + | |
| 86 | + | |
45 | 87 | | |
46 | | - | |
47 | | - | |
| 88 | + | |
| 89 | + | |
48 | 90 | | |
49 | 91 | | |
50 | 92 | | |
51 | 93 | | |
52 | 94 | | |
53 | | - | |
54 | | - | |
55 | | - | |
56 | | - | |
57 | | - | |
| 95 | + | |
58 | 96 | | |
59 | 97 | | |
60 | 98 | | |
61 | | - | |
62 | | - | |
| 99 | + | |
63 | 100 | | |
64 | 101 | | |
65 | 102 | | |
| |||
75 | 112 | | |
76 | 113 | | |
77 | 114 | | |
78 | | - | |
| 115 | + | |
79 | 116 | | |
80 | 117 | | |
81 | 118 | | |
| |||
84 | 121 | | |
85 | 122 | | |
86 | 123 | | |
87 | | - | |
| 124 | + | |
88 | 125 | | |
89 | 126 | | |
90 | 127 | | |
| |||
145 | 182 | | |
146 | 183 | | |
147 | 184 | | |
148 | | - | |
| 185 | + | |
149 | 186 | | |
150 | 187 | | |
151 | 188 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
9 | | - | |
10 | | - | |
| 8 | + | |
| 9 | + | |
11 | 10 | | |
12 | 11 | | |
13 | 12 | | |
| |||
251 | 250 | | |
252 | 251 | | |
253 | 252 | | |
254 | | - | |
255 | | - | |
256 | | - | |
257 | 253 | | |
258 | 254 | | |
259 | | - | |
260 | | - | |
261 | | - | |
262 | | - | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
263 | 259 | | |
264 | 260 | | |
| 261 | + | |
265 | 262 | | |
266 | 263 | | |
267 | 264 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | | - | |
| 21 | + | |
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
| |||
144 | 144 | | |
145 | 145 | | |
146 | 146 | | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
147 | 253 | | |
148 | 254 | | |
149 | 255 | | |
| |||
177 | 283 | | |
178 | 284 | | |
179 | 285 | | |
180 | | - | |
| 286 | + | |
181 | 287 | | |
182 | 288 | | |
183 | 289 | | |
| |||
186 | 292 | | |
187 | 293 | | |
188 | 294 | | |
189 | | - | |
| 295 | + | |
190 | 296 | | |
191 | 297 | | |
192 | 298 | | |
| |||
195 | 301 | | |
196 | 302 | | |
197 | 303 | | |
198 | | - | |
| 304 | + | |
199 | 305 | | |
200 | 306 | | |
201 | 307 | | |
| |||
204 | 310 | | |
205 | 311 | | |
206 | 312 | | |
207 | | - | |
| 313 | + | |
208 | 314 | | |
209 | 315 | | |
210 | 316 | | |
| |||
0 commit comments