|
| 1 | +import type { ClineMessage } from "@roo-code/types" |
| 2 | + |
| 3 | +import { MessageQueueService } from "../../message-queue/MessageQueueService" |
| 4 | +import { Task } from "../Task" |
| 5 | + |
| 6 | +function buildTask(getState: () => Promise<Record<string, unknown>>) { |
| 7 | + const task = Object.create(Task.prototype) as Task |
| 8 | + task["abort"] = false |
| 9 | + task["clineMessages"] = [] |
| 10 | + task["lastMessageTs"] = undefined |
| 11 | + task["addToClineMessages"] = vi.fn(async () => {}) |
| 12 | + task["saveClineMessages"] = vi.fn(async () => true) |
| 13 | + task["updateClineMessage"] = vi.fn(async () => {}) |
| 14 | + // Double assertion: `providerRef` is a `WeakRef<ClineProvider>`; `Task.ask` only calls `deref()` and `getState()`. |
| 15 | + task["providerRef"] = { deref: () => ({ getState }) } as unknown as Task["providerRef"] |
| 16 | + Object.defineProperty(task, "messageQueueService", { value: new MessageQueueService() }) |
| 17 | + return task |
| 18 | +} |
| 19 | + |
| 20 | +function deferred() { |
| 21 | + let release!: () => void |
| 22 | + const promise = new Promise<void>((resolve) => { |
| 23 | + release = resolve |
| 24 | + }) |
| 25 | + return { promise, release } |
| 26 | +} |
| 27 | + |
| 28 | +describe("Task.ask abort during the auto-approval await", () => { |
| 29 | + it.each([ |
| 30 | + ["complete", false], |
| 31 | + ["undefined", undefined], |
| 32 | + ["partial", true], |
| 33 | + ] as const)("does not add an ask row when aborted mid-await (partial=%s)", async (_label, partial) => { |
| 34 | + const gate = deferred() |
| 35 | + const task = buildTask(async () => { |
| 36 | + await gate.promise |
| 37 | + return { autoApprovalEnabled: true, alwaysAllowReadOnly: true } |
| 38 | + }) |
| 39 | + |
| 40 | + const askPromise = task.ask("tool", JSON.stringify({ tool: "readFile" }), partial) |
| 41 | + task["abort"] = true |
| 42 | + gate.release() |
| 43 | + |
| 44 | + await expect(askPromise).rejects.toThrow(/aborted/) |
| 45 | + expect(task["addToClineMessages"]).not.toHaveBeenCalled() |
| 46 | + expect(task["lastMessageTs"]).toBeUndefined() |
| 47 | + }) |
| 48 | + |
| 49 | + it.each([ |
| 50 | + ["partial update", true], |
| 51 | + ["partial completion", false], |
| 52 | + ] as const)("leaves an existing partial row untouched on %s when aborted mid-await", async (_label, partial) => { |
| 53 | + const gate = deferred() |
| 54 | + const task = buildTask(async () => { |
| 55 | + await gate.promise |
| 56 | + return {} |
| 57 | + }) |
| 58 | + const original: ClineMessage = { ts: 1, type: "ask", ask: "followup", text: "old", partial: true } |
| 59 | + task["clineMessages"] = [{ ...original }] |
| 60 | + |
| 61 | + const askPromise = task.ask("followup", "new", partial) |
| 62 | + task["abort"] = true |
| 63 | + gate.release() |
| 64 | + |
| 65 | + await expect(askPromise).rejects.toThrow(/aborted/) |
| 66 | + expect(task["clineMessages"]).toEqual([original]) |
| 67 | + expect(task["saveClineMessages"]).not.toHaveBeenCalled() |
| 68 | + expect(task["updateClineMessage"]).not.toHaveBeenCalled() |
| 69 | + expect(task["lastMessageTs"]).toBeUndefined() |
| 70 | + }) |
| 71 | + |
| 72 | + it("releases the claimed queued message when aborted mid-await", async () => { |
| 73 | + const gate = deferred() |
| 74 | + const task = buildTask(async () => { |
| 75 | + await gate.promise |
| 76 | + return {} |
| 77 | + }) |
| 78 | + task.messageQueueService.addMessage("queued feedback") |
| 79 | + |
| 80 | + const askPromise = task.ask("followup", "Q?", false) |
| 81 | + task["abort"] = true |
| 82 | + gate.release() |
| 83 | + |
| 84 | + await expect(askPromise).rejects.toThrow(/aborted/) |
| 85 | + expect(task["addToClineMessages"]).not.toHaveBeenCalled() |
| 86 | + expect(task.messageQueueService.claimNextMessage()?.text).toBe("queued feedback") |
| 87 | + }) |
| 88 | +}) |
0 commit comments