Skip to content

Commit 327a7d3

Browse files
refactor: align self-improving shared types
- reuse shared learning defaults and empty state from @roo-code/types - tighten experiment access to the shared Experiments contract - expand webview selfImprovingStatus typing to match manager output
1 parent f1210f7 commit 327a7d3

3 files changed

Lines changed: 40 additions & 48 deletions

File tree

‎packages/types/src/vscode-extension-host.ts‎

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -367,6 +367,22 @@ export type ExtensionState = Pick<
367367
patternCount: number
368368
eventCount: number
369369
actionCount: number
370+
memoryEntries: number
371+
memoryBackend?: string
372+
skillRecords: number
373+
curatorStatus: {
374+
lastRunAt: number
375+
firstRunDone: boolean
376+
config: {
377+
intervalMs: number
378+
minIdleMs: number
379+
firstRunDeferred: boolean
380+
staleAfterDays: number
381+
archiveAfterDays: number
382+
backupsEnabled: boolean
383+
maxBackups: number
384+
}
385+
}
370386
lastReviewAt?: number
371387
lastCuratorRunAt?: number
372388
}

‎src/services/self-improving/SelfImprovingManager.ts‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import type {
2+
Experiments,
23
ImprovementAction,
34
LearnedPattern,
45
LearningEvent,
@@ -36,7 +37,7 @@ type Runtime = {
3637
export class SelfImprovingManager {
3738
private readonly globalStoragePath: string
3839
private readonly logger: Logger
39-
private readonly getExperiments: () => Record<string, boolean> | undefined
40+
private readonly getExperiments: () => Experiments | undefined
4041
private readonly getCodeIndexInfo: SelfImprovingManagerOptions["getCodeIndexInfo"]
4142
public readonly memoryStore: MemoryBackend
4243
public readonly skillUsageStore: SkillUsageStore
@@ -77,7 +78,7 @@ export class SelfImprovingManager {
7778
this.transcriptRecall = new TranscriptRecall(options.globalStoragePath, options.logger)
7879
}
7980

80-
static isExperimentEnabled(experiments: Record<string, boolean> | undefined): boolean {
81+
static isExperimentEnabled(experiments: Experiments | undefined): boolean {
8182
if (!experiments) {
8283
return false
8384
}
@@ -135,7 +136,7 @@ export class SelfImprovingManager {
135136
* Handle settings change — called when experiments are updated.
136137
* This enables/disables the module at runtime.
137138
*/
138-
async onSettingsChanged(_experiments: Record<string, boolean> | undefined): Promise<void> {
139+
async onSettingsChanged(_experiments: Experiments | undefined): Promise<void> {
139140
await this.handleExperimentChange()
140141
}
141142

‎src/services/self-improving/types.ts‎

Lines changed: 20 additions & 45 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,23 @@
1-
import type {
2-
ActionType,
3-
FeedbackSignal,
4-
ImprovementAction,
5-
LearnedPattern,
6-
LearningConfig,
7-
LearningEvent,
8-
LearningState,
9-
LearningTelemetry,
10-
PatternState,
11-
PatternType,
1+
import {
2+
DEFAULT_LEARNING_CONFIG,
3+
EMPTY_LEARNING_STATE,
4+
type ActionType,
5+
type Experiments,
6+
type FeedbackSignal,
7+
type ImprovementAction,
8+
type LearnedPattern,
9+
type LearningConfig,
10+
type LearningEvent,
11+
type LearningState,
12+
type LearningTelemetry,
13+
type PatternState,
14+
type PatternType,
1215
} from "@roo-code/types"
1316

1417
// Re-export shared types for convenience
1518
export type {
1619
ActionType,
20+
Experiments,
1721
FeedbackSignal,
1822
ImprovementAction,
1923
LearnedPattern,
@@ -75,7 +79,7 @@ export interface PromptContext {
7579
export interface SelfImprovingManagerOptions {
7680
globalStoragePath: string
7781
logger: Logger
78-
getExperiments: () => Record<string, boolean> | undefined
82+
getExperiments: () => Experiments | undefined
7983
getCodeIndexInfo?: () => CodeIndexInfo
8084
/** Memory backend type: "builtin" (default) or "agentmemory" */
8185
memoryBackend?: "builtin" | "agentmemory"
@@ -99,40 +103,11 @@ export interface SelfImprovingManagerOptions {
99103
}
100104

101105
/**
102-
* Default learning configuration
106+
* Shared learning defaults re-exported for local convenience.
103107
*/
104-
export const DEFAULT_CONFIG: LearningConfig = {
105-
enabled: false,
106-
reviewOnTurnCount: 10,
107-
reviewOnToolIterationCount: 50,
108-
maxStoredPatterns: 100,
109-
maxStoredEvents: 500,
110-
maxPromptPatterns: 5,
111-
curatorEnabled: true,
112-
curatorIntervalMs: 3600000,
113-
staleAfterDays: 14,
114-
archiveAfterDays: 60,
115-
codeIndexCorrelationEnabled: true,
116-
}
108+
export const DEFAULT_CONFIG: LearningConfig = DEFAULT_LEARNING_CONFIG
117109

118110
/**
119-
* Empty learning state for initialization
111+
* Shared empty learning state re-exported for local convenience.
120112
*/
121-
export const EMPTY_STATE: LearningState = {
122-
version: 1,
123-
config: DEFAULT_CONFIG,
124-
counters: {
125-
userTurnsSinceReview: 0,
126-
toolIterationsSinceReview: 0,
127-
},
128-
patterns: [],
129-
archivedPatterns: [],
130-
recentEvents: [],
131-
pendingActions: [],
132-
telemetry: {
133-
promptEnrichmentUses: 0,
134-
toolPreferenceUses: 0,
135-
errorAvoidanceUses: 0,
136-
skillSuggestionCount: 0,
137-
},
138-
}
113+
export const EMPTY_STATE: LearningState = EMPTY_LEARNING_STATE

0 commit comments

Comments
 (0)