Repository navigation
Commit 320fd43
committed
test: fix describe nesting, strengthen prune assertion, make stale-entry
check deterministic, restore timers in finally
Review round on this unit's test quality: the viewStates describe block was
nested inside the alwaysDenyUnapprovedCommands block, so reported test names
carried the wrong subject; the prune test asserted survival with toDefined(),
which passes even if pruning strips fields - the surviving entries are fully
known, so assert their exact shape (matching the parallel-mode suite); the
stale-temporary-entry test waited on a fixed 10 ms timer, so a slow load
could let the negative assertion pass vacuously - await the load itself;
the readiness-cancel test left fake timers active when an assertion failed
before the restore line, hanging a later real-timer test - restore in a
finally block.
Proofs: global-settings 9/9, ClineProvider.spec 294/294, sticky-mode 33/33,
api-task-control 23/23; negative controls: pruning that strips updatedAt
reddens exactly the prune test, a loadViewState that adopts the unowned
temporary-id entry reddens exactly the stale-entry test, restores
byte-exact (hash match); eslint --max-warnings=0 clean (src and types);
prettier clean.1 parent eb27fac commit 320fd43
3 files changed
Lines changed: 29 additions & 28 deletions
File tree
- packages/types/src/__tests__
- src/core/webview/__tests__
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
| 40 | + | |
40 | 41 | | |
41 | | - | |
42 | | - | |
43 | | - | |
44 | | - | |
45 | | - | |
46 | | - | |
47 | | - | |
48 | | - | |
49 | | - | |
50 | | - | |
51 | | - | |
52 | | - | |
53 | | - | |
54 | | - | |
55 | | - | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
56 | 49 | | |
57 | | - | |
58 | | - | |
59 | | - | |
60 | | - | |
61 | | - | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
62 | 54 | | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
63 | 58 | | |
64 | | - | |
65 | | - | |
66 | | - | |
67 | | - | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
68 | 68 | | |
69 | 69 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2377 | 2377 | | |
2378 | 2378 | | |
2379 | 2379 | | |
2380 | | - | |
2381 | | - | |
| 2380 | + | |
| 2381 | + | |
2382 | 2382 | | |
2383 | 2383 | | |
2384 | 2384 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1674 | 1674 | | |
1675 | 1675 | | |
1676 | 1676 | | |
1677 | | - | |
1678 | | - | |
| 1677 | + | |
| 1678 | + | |
| 1679 | + | |
1679 | 1680 | | |
1680 | 1681 | | |
1681 | 1682 | | |
| |||
0 commit comments