Repository navigation
Commit 2e932e8
committed
fix: serialize profile mutations across views and keep sibling tasks on
the deleted profile when a re-pin fails
Review round on this unit: (1) providerProfileMutationQueue belonged to each
ClineProvider, but profile mutations rewrite the shared ContextProxy stores -
a second view could commit between the first view's shared write and its
snapshot compensation, and the compensation would restore a stale copy over
the newer write. The queue is now shared across instances, serializing every
view's profile mutations against each other. (2) The sibling re-pin switched
each successful view's task to the replacement's API handler and sticky
profile name inside the per-sibling loop: when a later sibling's re-pin
rejected, the rollback restored the pins but not the tasks, leaving a
rolled-back view's conversation on the replacement profile after the
deletion failed. Task updates now run only after every sibling's re-pin
landed.
Proofs: ClineProvider.spec 306/306 (new cross-instance serialization test),
parallel-mode 19/19 (new sibling-task rollback test), sticky-mode 32/32;
negative controls: making the queue per-instance again reddens exactly the
serialization test, moving the task updates back before the success check
reddens exactly the sibling-task test, restores byte-exact (hash match);
eslint --max-warnings=0 clean; tsc clean; prettier clean.1 parent b375467 commit 2e932e8
3 files changed
Lines changed: 165 additions & 16 deletions
File tree
- src/core/webview
- __tests__
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
321 | 321 | | |
322 | 322 | | |
323 | 323 | | |
324 | | - | |
| 324 | + | |
| 325 | + | |
| 326 | + | |
| 327 | + | |
| 328 | + | |
325 | 329 | | |
326 | 330 | | |
327 | 331 | | |
| |||
335 | 339 | | |
336 | 340 | | |
337 | 341 | | |
338 | | - | |
| 342 | + | |
339 | 343 | | |
340 | 344 | | |
341 | 345 | | |
| |||
366 | 370 | | |
367 | 371 | | |
368 | 372 | | |
369 | | - | |
| 373 | + | |
370 | 374 | | |
371 | 375 | | |
372 | 376 | | |
| |||
3375 | 3379 | | |
3376 | 3380 | | |
3377 | 3381 | | |
3378 | | - | |
3379 | | - | |
3380 | | - | |
3381 | | - | |
3382 | | - | |
3383 | | - | |
3384 | | - | |
3385 | | - | |
3386 | | - | |
3387 | | - | |
3388 | 3382 | | |
3389 | 3383 | | |
3390 | 3384 | | |
| |||
3411 | 3405 | | |
3412 | 3406 | | |
3413 | 3407 | | |
| 3408 | + | |
| 3409 | + | |
| 3410 | + | |
| 3411 | + | |
| 3412 | + | |
| 3413 | + | |
| 3414 | + | |
| 3415 | + | |
| 3416 | + | |
| 3417 | + | |
| 3418 | + | |
| 3419 | + | |
| 3420 | + | |
| 3421 | + | |
| 3422 | + | |
| 3423 | + | |
3414 | 3424 | | |
3415 | 3425 | | |
3416 | 3426 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1176 | 1176 | | |
1177 | 1177 | | |
1178 | 1178 | | |
| 1179 | + | |
| 1180 | + | |
| 1181 | + | |
| 1182 | + | |
| 1183 | + | |
| 1184 | + | |
| 1185 | + | |
| 1186 | + | |
| 1187 | + | |
| 1188 | + | |
| 1189 | + | |
| 1190 | + | |
| 1191 | + | |
| 1192 | + | |
| 1193 | + | |
| 1194 | + | |
| 1195 | + | |
| 1196 | + | |
| 1197 | + | |
| 1198 | + | |
| 1199 | + | |
| 1200 | + | |
| 1201 | + | |
| 1202 | + | |
| 1203 | + | |
| 1204 | + | |
| 1205 | + | |
| 1206 | + | |
| 1207 | + | |
| 1208 | + | |
| 1209 | + | |
| 1210 | + | |
| 1211 | + | |
| 1212 | + | |
| 1213 | + | |
| 1214 | + | |
| 1215 | + | |
| 1216 | + | |
| 1217 | + | |
| 1218 | + | |
| 1219 | + | |
| 1220 | + | |
| 1221 | + | |
| 1222 | + | |
| 1223 | + | |
| 1224 | + | |
| 1225 | + | |
| 1226 | + | |
| 1227 | + | |
| 1228 | + | |
| 1229 | + | |
| 1230 | + | |
| 1231 | + | |
| 1232 | + | |
| 1233 | + | |
| 1234 | + | |
| 1235 | + | |
| 1236 | + | |
| 1237 | + | |
| 1238 | + | |
| 1239 | + | |
| 1240 | + | |
| 1241 | + | |
| 1242 | + | |
| 1243 | + | |
| 1244 | + | |
| 1245 | + | |
| 1246 | + | |
| 1247 | + | |
| 1248 | + | |
| 1249 | + | |
| 1250 | + | |
| 1251 | + | |
| 1252 | + | |
| 1253 | + | |
| 1254 | + | |
| 1255 | + | |
| 1256 | + | |
| 1257 | + | |
| 1258 | + | |
| 1259 | + | |
| 1260 | + | |
| 1261 | + | |
| 1262 | + | |
| 1263 | + | |
| 1264 | + | |
| 1265 | + | |
| 1266 | + | |
| 1267 | + | |
| 1268 | + | |
| 1269 | + | |
| 1270 | + | |
| 1271 | + | |
1179 | 1272 | | |
1180 | 1273 | | |
1181 | 1274 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2763 | 2763 | | |
2764 | 2764 | | |
2765 | 2765 | | |
| 2766 | + | |
| 2767 | + | |
| 2768 | + | |
| 2769 | + | |
| 2770 | + | |
| 2771 | + | |
| 2772 | + | |
| 2773 | + | |
| 2774 | + | |
| 2775 | + | |
| 2776 | + | |
| 2777 | + | |
| 2778 | + | |
| 2779 | + | |
| 2780 | + | |
| 2781 | + | |
| 2782 | + | |
| 2783 | + | |
| 2784 | + | |
| 2785 | + | |
| 2786 | + | |
| 2787 | + | |
| 2788 | + | |
| 2789 | + | |
| 2790 | + | |
| 2791 | + | |
| 2792 | + | |
| 2793 | + | |
| 2794 | + | |
| 2795 | + | |
| 2796 | + | |
| 2797 | + | |
| 2798 | + | |
| 2799 | + | |
| 2800 | + | |
| 2801 | + | |
| 2802 | + | |
| 2803 | + | |
| 2804 | + | |
| 2805 | + | |
| 2806 | + | |
| 2807 | + | |
| 2808 | + | |
| 2809 | + | |
| 2810 | + | |
| 2811 | + | |
2766 | 2812 | | |
2767 | 2813 | | |
2768 | 2814 | | |
| |||
3888 | 3934 | | |
3889 | 3935 | | |
3890 | 3936 | | |
3891 | | - | |
| 3937 | + | |
3892 | 3938 | | |
3893 | 3939 | | |
3894 | 3940 | | |
| |||
3980 | 4026 | | |
3981 | 4027 | | |
3982 | 4028 | | |
3983 | | - | |
| 4029 | + | |
3984 | 4030 | | |
3985 | 4031 | | |
3986 | 4032 | | |
| |||
4057 | 4103 | | |
4058 | 4104 | | |
4059 | 4105 | | |
4060 | | - | |
| 4106 | + | |
4061 | 4107 | | |
4062 | 4108 | | |
4063 | 4109 | | |
| |||
0 commit comments