Repository navigation
Commit 2c94a81
committed
fix(editor,write-to-file): report a refused tab close, and stop a delta that died mid-open
Two rows on PR 1930, one shape each.
The abandoned-pre-open callback closes the plain tab it can prove it opened, and nothing
awaited that close: a rejection landed in the extension host as an unhandled rejection
instead of as a fact about a tab that is still standing. It is reported the way a refused
close is reported everywhere else in the class.
A partial delta that stops while its own open() is in flight used to fall straight into
update() against the preview open() had just installed: content no delta will ever approve,
in a view no delta is left to bring to approval. The cancellation guard the flow already
asks at every other await boundary now runs here too, and the abandoned stream tears down
the preview the same way the diff-view failure path does.
Each leg has a case that fails without the source change: the cancellation case at the
revert assertion, and the tab case at the log assertion.
Reviewed rows: PRRT_kwDOSK-bwM60-lz_ (DiffViewProvider tab close) and
PRRT_kwDOSK-bwM606auD (WriteToFileTool open/update boundary).1 parent 6403f98 commit 2c94a81
4 files changed
Lines changed: 71 additions & 1 deletion
File tree
- src
- core/tools
- __tests__
- integrations/editor
- __tests__
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
771 | 771 | | |
772 | 772 | | |
773 | 773 | | |
| 774 | + | |
| 775 | + | |
| 776 | + | |
| 777 | + | |
| 778 | + | |
| 779 | + | |
| 780 | + | |
| 781 | + | |
| 782 | + | |
| 783 | + | |
| 784 | + | |
| 785 | + | |
774 | 786 | | |
775 | 787 | | |
776 | 788 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
141 | 141 | | |
142 | 142 | | |
143 | 143 | | |
| 144 | + | |
| 145 | + | |
144 | 146 | | |
145 | 147 | | |
146 | 148 | | |
| |||
161 | 163 | | |
162 | 164 | | |
163 | 165 | | |
| 166 | + | |
| 167 | + | |
164 | 168 | | |
165 | 169 | | |
166 | 170 | | |
| |||
288 | 292 | | |
289 | 293 | | |
290 | 294 | | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
| 308 | + | |
| 309 | + | |
| 310 | + | |
| 311 | + | |
| 312 | + | |
| 313 | + | |
| 314 | + | |
| 315 | + | |
| 316 | + | |
291 | 317 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1410 | 1410 | | |
1411 | 1411 | | |
1412 | 1412 | | |
1413 | | - | |
| 1413 | + | |
| 1414 | + | |
| 1415 | + | |
| 1416 | + | |
| 1417 | + | |
| 1418 | + | |
1414 | 1419 | | |
1415 | 1420 | | |
1416 | 1421 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3238 | 3238 | | |
3239 | 3239 | | |
3240 | 3240 | | |
| 3241 | + | |
| 3242 | + | |
| 3243 | + | |
| 3244 | + | |
| 3245 | + | |
| 3246 | + | |
| 3247 | + | |
| 3248 | + | |
| 3249 | + | |
| 3250 | + | |
| 3251 | + | |
| 3252 | + | |
| 3253 | + | |
| 3254 | + | |
| 3255 | + | |
| 3256 | + | |
| 3257 | + | |
| 3258 | + | |
| 3259 | + | |
| 3260 | + | |
| 3261 | + | |
| 3262 | + | |
| 3263 | + | |
| 3264 | + | |
| 3265 | + | |
| 3266 | + | |
| 3267 | + | |
3241 | 3268 | | |
3242 | 3269 | | |
3243 | 3270 | | |
| |||
0 commit comments