Repository navigation
Commit 281c245
committed
test(safeWriteJson): key the backup-stat injection on inode, not path spelling
The three "preserve backups when another backup stat fails with ENOENT/
EACCES/EIO" rows went red on the windows platform-unit shard (#1914 CI run
42448302148 job 128631851822): the double compared the stat target against
os.tmpdir()'s spelling while the writer stats the canonical form of the same
file - on windows realpath spells it differently - so the injection missed,
stat succeeded, and the write resolved instead of rejecting (the failure
reads: 'promise resolved "undefined" instead of rejecting' at
safeWriteJson.test.ts:675 on run 42461215177 job 128670729075).
This adopts #2359's (025fb7d) hardened version of the test file, which keys
the injection on the leftover's inode and restores the fs.stat implementation
after the row (inode recycling otherwise rejects later tests). Test-only:
src/utils/safeWriteJson.ts is byte-identical between 74f5eb2 and 025fb7d,
so the json implementation stays at this branch's pin and json + its specs
still travel as one generation - with the pair windows-proven: 025fb7d's
windows platform-unit passed with this exact test file against the identical
implementation (run 42455872567 job 128654644966). Copy source named:
src/utils/__tests__/safeWriteJson.test.ts from 025fb7d (#2359 head).1 parent 74f5eb2 commit 281c245
1 file changed
Lines changed: 31 additions & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
660 | 660 | | |
661 | 661 | | |
662 | 662 | | |
| 663 | + | |
| 664 | + | |
| 665 | + | |
| 666 | + | |
| 667 | + | |
| 668 | + | |
| 669 | + | |
| 670 | + | |
| 671 | + | |
| 672 | + | |
| 673 | + | |
| 674 | + | |
| 675 | + | |
| 676 | + | |
| 677 | + | |
| 678 | + | |
| 679 | + | |
| 680 | + | |
663 | 681 | | |
664 | | - | |
| 682 | + | |
665 | 683 | | |
666 | 684 | | |
667 | 685 | | |
668 | 686 | | |
669 | 687 | | |
670 | 688 | | |
671 | | - | |
672 | | - | |
673 | | - | |
674 | | - | |
675 | | - | |
676 | | - | |
677 | | - | |
678 | | - | |
| 689 | + | |
| 690 | + | |
| 691 | + | |
| 692 | + | |
| 693 | + | |
| 694 | + | |
| 695 | + | |
| 696 | + | |
| 697 | + | |
| 698 | + | |
| 699 | + | |
| 700 | + | |
679 | 701 | | |
680 | 702 | | |
681 | 703 | | |
| |||
0 commit comments