You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 22969c6
Browse filesBrowse the repository at this point in the historyBrowse files
fix(u5): stop a timed-out acquisition from opening a diff nobody is waiting for
openDiffEditor() races a ten-second timer against a showTextDocument it cannot cancel. The timeout
rejected the acquisition and disposed the listeners, but nothing stopped the follow-up callback from running
the diff command anyway: the tab opened after the caller had already been told the acquisition failed, with
no listener left to adopt it, and the original side of that diff was built from whatever the provider field
held at that moment rather than the content the acquisition was asked to compare against. That second half
matters more now than it did, because a failed recovery re-acquisition restores the previous baseline: a
late callback used to see the captured one and now sees the restored one.
The command is skipped once the acquisition has abandoned the path, and the compared content is captured when
the acquisition starts. Behaviour is unchanged for an acquisition that settles in time: the captured value is
the live value there. The capture is not extended into the buffer restore, which still reads the live field -
that is a second decision this row did not ask for, and it is said in-thread rather than slipped in.
Gates and controls at node v22.23.4: this spec 97 passed (97), status 0; the whole misc layer 117 passed | 1
skipped files, 2118 passed | 13 skipped (2131), status 0; vitest.core.config.ts 198 files 4294 passed | 9
skipped, status 0; tsc --noEmit -p tsconfig.json 0 errors; eslint --max-warnings=0 --no-cache over src status
0; prettier --check clean; suppression counts unchanged at 265 files / 2870 entries. Controls: deleting the
abandon check makes the timeout case fail ('expected vi.fn() to not be called at all, but actually been called
1 times', status 1), and reading the live field instead of the captured one makes the baseline case fail
(expected ['c3dhcHBlZCBtaWQtZmxpZ2h0'] to deeply equal ['Y2FwdHVyZWQgYXQgYWNxdWlzaXRpb24='], status 1). The
component was written back byte-for-byte after each control and re-run green.
Not pushed with 7a1a710: that round's single push was spent, and the Lead fixed 7bf8573 as the next head,
so which head carries this commit is the Lead's call.
0 commit comments