Skip to content

Commit 1d78f74

Browse files
zoomote2[bot]roomoteedelauna
authored
[Refactor] Remove no-explicit-any suppressions: batch 2 (small directories) (#2286)
* refactor: remove no-explicit-any suppressions in small directories * test: expand URI callback coverage and address review feedback --------- Co-authored-by: Roomote <[email protected]> Co-authored-by: Elliott de Launay <[email protected]>
1 parent c71705e commit 1d78f74

36 files changed

Lines changed: 551 additions & 477 deletions

‎packages/types/src/task.ts‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -147,6 +147,9 @@ export type TaskEvents = {
147147
[RooCodeEventName.TaskPaused]: [taskId: string]
148148
[RooCodeEventName.TaskUnpaused]: [taskId: string]
149149
[RooCodeEventName.TaskSpawned]: [taskId: string]
150+
[RooCodeEventName.TaskDelegated]: [childTaskId: string]
151+
[RooCodeEventName.TaskDelegationCompleted]: [childTaskId: string, summary: string]
152+
[RooCodeEventName.TaskDelegationResumed]: [childTaskId: string]
150153

151154
// Task Execution
152155
[RooCodeEventName.Message]: [{ action: "created" | "updated"; message: ClineMessage }]

‎src/__mocks__/fs/promises.ts‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ const mockFs = {
8080

8181
// Handle file not found
8282
const error = new Error(`ENOENT: no such file or directory, open '${filePath}'`)
83-
;(error as any).code = "ENOENT"
83+
;(error as NodeJS.ErrnoException).code = "ENOENT"
8484
throw error
8585
}),
8686

@@ -113,7 +113,7 @@ const mockFs = {
113113
currentPath += "/" + parts[i]
114114
if (!mockDirectories.has(currentPath)) {
115115
const error = new Error(`ENOENT: no such file or directory, mkdir '${path}'`)
116-
;(error as any).code = "ENOENT"
116+
;(error as NodeJS.ErrnoException).code = "ENOENT"
117117
throw error
118118
}
119119
}
@@ -130,7 +130,7 @@ const mockFs = {
130130
return Promise.resolve()
131131
}
132132
const error = new Error(`ENOENT: no such file or directory, access '${path}'`)
133-
;(error as any).code = "ENOENT"
133+
;(error as NodeJS.ErrnoException).code = "ENOENT"
134134
throw error
135135
}),
136136

@@ -146,7 +146,7 @@ const mockFs = {
146146
}
147147
// If old file doesn't exist, throw an error
148148
const error = new Error(`ENOENT: no such file or directory, rename '${oldPath}'`)
149-
;(error as any).code = "ENOENT"
149+
;(error as NodeJS.ErrnoException).code = "ENOENT"
150150
throw error
151151
}),
152152

‎src/__tests__/ClineProvider.delegation.spec.ts‎

Lines changed: 18 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -40,16 +40,15 @@ function makeStoreStub(
4040
* `parent`. Without flushPendingToolResultsToHistory the method hits its
4141
* non-fatal flush-error branch and never reaches the happy delegation path.
4242
*/
43-
const makeParentTask = () =>
44-
({
45-
taskId: "parent-1",
46-
apiConfiguration: { apiProvider: providerIdentifiers.anthropic, anthropicApiKey: "task-local-key" },
47-
getTaskMode: vi.fn().mockResolvedValue("code"),
48-
getTaskApiConfigName: vi.fn().mockResolvedValue("task-local-profile"),
49-
emit: vi.fn(),
50-
flushPendingToolResultsToHistory: vi.fn().mockResolvedValue(true),
51-
retrySaveApiConversationHistory: vi.fn(),
52-
}) as any
43+
const makeParentTask = () => ({
44+
taskId: "parent-1",
45+
apiConfiguration: { apiProvider: providerIdentifiers.anthropic, anthropicApiKey: "task-local-key" },
46+
getTaskMode: vi.fn().mockResolvedValue("code"),
47+
getTaskApiConfigName: vi.fn().mockResolvedValue("task-local-profile"),
48+
emit: vi.fn(),
49+
flushPendingToolResultsToHistory: vi.fn().mockResolvedValue(true),
50+
retrySaveApiConversationHistory: vi.fn(),
51+
})
5352

5453
describe("ClineProvider.delegateParentAndOpenChild()", () => {
5554
it("rejects a stale restored action before delegation side effects", async () => {
@@ -150,7 +149,7 @@ describe("ClineProvider.delegateParentAndOpenChild()", () => {
150149
}
151150
const parentTask = makeParentTask()
152151
const child = { taskId: "child-1", run: vi.fn().mockResolvedValue(undefined) }
153-
const getCurrentTask = vi.fn(() => parentTask)
152+
const getCurrentTask = vi.fn((): { taskId: string } => parentTask)
154153
const createTask = vi.fn(async () => {
155154
getCurrentTask.mockReturnValue(child)
156155
return child
@@ -218,7 +217,7 @@ describe("ClineProvider.delegateParentAndOpenChild()", () => {
218217
taskHistoryStore,
219218
} as unknown as ClineProvider
220219

221-
const child = await (ClineProvider.prototype as any).delegateParentAndOpenChild.call(provider, {
220+
const child = await ClineProvider.prototype.delegateParentAndOpenChild.call(provider, {
222221
parentTaskId: "parent-1",
223222
message: "Do something",
224223
initialTodos: [],
@@ -416,7 +415,7 @@ describe("ClineProvider.delegateParentAndOpenChild()", () => {
416415
taskHistoryStore,
417416
} as unknown as ClineProvider
418417

419-
await (ClineProvider.prototype as any).delegateParentAndOpenChild.call(provider, {
418+
await ClineProvider.prototype.delegateParentAndOpenChild.call(provider, {
420419
parentTaskId: "parent-1",
421420
message: "Do something",
422421
initialTodos: [],
@@ -450,7 +449,7 @@ describe("ClineProvider.delegateParentAndOpenChild()", () => {
450449
taskHistoryStore,
451450
} as unknown as ClineProvider
452451

453-
await (ClineProvider.prototype as any).delegateParentAndOpenChild.call(provider, {
452+
await ClineProvider.prototype.delegateParentAndOpenChild.call(provider, {
454453
parentTaskId: "parent-1",
455454
message: "Do something",
456455
initialTodos: [],
@@ -491,7 +490,7 @@ describe("ClineProvider.delegateParentAndOpenChild()", () => {
491490
taskHistoryStore,
492491
} as unknown as ClineProvider
493492

494-
await (ClineProvider.prototype as any).delegateParentAndOpenChild.call(provider, {
493+
await ClineProvider.prototype.delegateParentAndOpenChild.call(provider, {
495494
parentTaskId: "parent-1",
496495
message: "Do something",
497496
initialTodos: [],
@@ -538,7 +537,7 @@ describe("ClineProvider.delegateParentAndOpenChild()", () => {
538537
taskHistoryStore,
539538
} as unknown as ClineProvider
540539

541-
await (ClineProvider.prototype as any).delegateParentAndOpenChild.call(provider, {
540+
await ClineProvider.prototype.delegateParentAndOpenChild.call(provider, {
542541
parentTaskId: "parent-1",
543542
message: "Continue",
544543
initialTodos: [],
@@ -603,7 +602,7 @@ describe("ClineProvider.delegateParentAndOpenChild()", () => {
603602
} as unknown as ClineProvider
604603

605604
await expect(
606-
(ClineProvider.prototype as any).delegateParentAndOpenChild.call(provider, {
605+
ClineProvider.prototype.delegateParentAndOpenChild.call(provider, {
607606
parentTaskId: "parent-1",
608607
message: "Continue",
609608
initialTodos: [],
@@ -614,7 +613,7 @@ describe("ClineProvider.delegateParentAndOpenChild()", () => {
614613
// The authoritative preflight rejects before either provider mutates its stack.
615614
expect(child.run).not.toHaveBeenCalled()
616615
expect(createTask).not.toHaveBeenCalled()
617-
expect((provider as any).deleteTaskWithId).not.toHaveBeenCalled()
616+
expect(provider.deleteTaskWithId).not.toHaveBeenCalled()
618617
})
619618

620619
it("rejects a delegated parent whose awaited-child identity is missing", async () => {
@@ -744,7 +743,7 @@ describe("ClineProvider.delegateParentAndOpenChild()", () => {
744743
} as unknown as ClineProvider
745744

746745
await expect(
747-
(ClineProvider.prototype as any).delegateParentAndOpenChild.call(provider, {
746+
ClineProvider.prototype.delegateParentAndOpenChild.call(provider, {
748747
parentTaskId: "parent-1",
749748
message: "Do something",
750749
initialTodos: [],

0 commit comments

Comments
 (0)