Skip to content

Commit 1cf4f0d

Browse files
committed
test(experiments): cover explicit false and omitted dynamic thinking effort states
1 parent a05830c commit 1cf4f0d

2 files changed

Lines changed: 51 additions & 0 deletions

File tree

‎src/shared/__tests__/experiments.spec.ts‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -88,5 +88,9 @@ describe("experiments", () => {
8888
it("returns true when enabled", () => {
8989
expect(Experiments.isEnabled({ dynamicThinkingEffort: true }, "dynamicThinkingEffort")).toBe(true)
9090
})
91+
92+
it("returns false when explicitly disabled", () => {
93+
expect(Experiments.isEnabled({ dynamicThinkingEffort: false }, "dynamicThinkingEffort")).toBe(false)
94+
})
9195
})
9296
})

‎webview-ui/src/components/settings/__tests__/ExperimentalSettings.spec.tsx‎

Lines changed: 47 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,32 @@ describe("ExperimentalSettings", () => {
3939
expect(screen.getByText("settings:experimental.DYNAMIC_THINKING_EFFORT.name")).toBeInTheDocument()
4040
})
4141

42+
it("leaves the dynamic thinking effort toggle unchecked when the value is false or omitted", () => {
43+
const getCheckbox = () => {
44+
const label = screen.getByText("settings:experimental.DYNAMIC_THINKING_EFFORT.name").closest("label")
45+
return label?.querySelector("input[type='checkbox']")
46+
}
47+
48+
// Explicit false
49+
let result = render(
50+
<ExperimentalSettings
51+
{...defaultProps}
52+
experiments={{ ...experimentDefault, dynamicThinkingEffort: false }}
53+
/>,
54+
)
55+
expect(getCheckbox()).not.toBeNull()
56+
expect(getCheckbox()).not.toBeChecked()
57+
result.unmount()
58+
59+
// Omitted (absent from the persisted config)
60+
const omitted: Record<string, boolean> = { ...experimentDefault }
61+
delete omitted.dynamicThinkingEffort
62+
result = render(<ExperimentalSettings {...defaultProps} experiments={omitted} />)
63+
expect(getCheckbox()).not.toBeNull()
64+
expect(getCheckbox()).not.toBeChecked()
65+
result.unmount()
66+
})
67+
4268
it("binds the dynamic thinking effort toggle to setExperimentEnabled", () => {
4369
const setExperimentEnabled = vi.fn()
4470
render(
@@ -59,4 +85,25 @@ describe("ExperimentalSettings", () => {
5985
expect(setExperimentEnabled).toHaveBeenCalledTimes(1)
6086
expect(setExperimentEnabled).toHaveBeenCalledWith("dynamicThinkingEffort", false)
6187
})
88+
89+
it("toggles the dynamic thinking effort on when clicked from the unchecked state", () => {
90+
const setExperimentEnabled = vi.fn()
91+
render(
92+
<ExperimentalSettings
93+
{...defaultProps}
94+
experiments={{ ...experimentDefault, dynamicThinkingEffort: false }}
95+
setExperimentEnabled={setExperimentEnabled}
96+
/>,
97+
)
98+
99+
const label = screen.getByText("settings:experimental.DYNAMIC_THINKING_EFFORT.name").closest("label")
100+
const checkbox = label?.querySelector("input[type='checkbox']")
101+
expect(checkbox).not.toBeNull()
102+
expect(checkbox).not.toBeChecked()
103+
104+
fireEvent.click(checkbox!)
105+
106+
expect(setExperimentEnabled).toHaveBeenCalledTimes(1)
107+
expect(setExperimentEnabled).toHaveBeenCalledWith("dynamicThinkingEffort", true)
108+
})
62109
})

0 commit comments

Comments
 (0)