Repository navigation
Commit 1b04a75
test(webview): pin that the rename target read follows the save, not just the other lookup
The rename case asserted which name each getProfile call used, which is not the same as asserting
when the target read happened. A read that ran before saveConfig would still be the second call with
the second name, while the real manager rejects a lookup of a profile that has not been written yet.
Control on pinned node v22.23.4 (.tmp-node22): moving the target read above the save in
webviewMessageHandler.ts (line-level swap of :2632 and :2644, blob 80e1da20ec8d) fails the new line
with "expected 739 to be greater than 740" at the toBeGreaterThan; the same mutant also breaks eight
sibling rename cases because the swap changes which call's result is used, so it is a coarse mutant,
not a minimal one - the ordering line is the one that names the defect. With the handler blob restored
to df7f0c0 (verified by git hash-object) the file is 180/180.
Gates: focused spec 180/180, vitest.core.config.ts 4482 passed and vitest.misc.config.ts 2113 passed on
pinned v22.23.4; tsc --noEmit and knip --treat-config-hints-as-errors clean on box node v25.9.0;
eslint --max-warnings=0 clean with .eslintcache deleted after the last prettier write; prettier --check
clean before and after --write; src/eslint-suppressions.json left at the parent blob 57dbc2b. The
handler is unchanged (blob df7f0c0 before and after), so this is test-only and does not move any
behaviour.
Co-Authored-By: Claude <[email protected]>1 parent 21741e5 commit 1b04a75
1 file changed
Lines changed: 10 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3206 | 3206 | | |
3207 | 3207 | | |
3208 | 3208 | | |
| 3209 | + | |
3209 | 3210 | | |
3210 | 3211 | | |
3211 | 3212 | | |
3212 | 3213 | | |
3213 | 3214 | | |
3214 | | - | |
| 3215 | + | |
3215 | 3216 | | |
3216 | 3217 | | |
3217 | 3218 | | |
| |||
3233 | 3234 | | |
3234 | 3235 | | |
3235 | 3236 | | |
| 3237 | + | |
| 3238 | + | |
| 3239 | + | |
| 3240 | + | |
| 3241 | + | |
| 3242 | + | |
| 3243 | + | |
| 3244 | + | |
3236 | 3245 | | |
3237 | 3246 | | |
3238 | 3247 | | |
| |||
0 commit comments