You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 19954d3
Browse filesBrowse the repository at this point in the historyBrowse files
fix(task): harden set_thinking_effort per review feedback
Address PR review feedback on set_thinking_effort (DTE series 3/5):
- Executor: seed the per-task guard history with the task's effective
baseline so returning from a changed value to the original baseline is
refused as oscillation (A -> B -> A); existing no-op behavior preserved.
- Parser: only build nativeArgs when effort AND reason are strings; a
non-string payload now fails at parse time and cannot reach the executor.
- Gating: a supportsReasoningEffort array that only lists 'disable' no
longer exposes the tool (it could apply no level).
- i18n: translate the new thinkingEffort chat strings into all 17
non-English webview locales (placeholders preserved).
- Tests: regression tests for each change plus branch-coverage for the
previously partial lines (non-string args, 'disable'-only capability,
baseline oscillation, partial streaming without params, description
fallback, capability robustness). All touched patch lines are now
fully branch-covered (codecov patch partials resolved).
CodeRabbit: #1354
0 commit comments