Repository navigation
Commit 1971923
committed
fix(webview): keep the view overlay consistent with the pin on a failed activation write
activateProviderProfileUnlocked clears this view's apiConfiguration overlay in the same
Promise.all as the shared settings write, so a partial failure left the view holding the
activated profile's pin with no overlay at all: getState() then paired the new name with
whatever the shared store held, out of step with the handler the failure path had just
force-rebuilt.
The legs are not atomic with each other, so the failure path now decides after every leg
has settled - allSettled rather than all, matching upsertProviderProfile - and puts the
overlay in the state that agrees with the pin this view actually holds: the activated
settings when the pin write took the new name, which is the invariant
refreshViewLocalStateForUpdatedProfile enforces on the success path and the configuration
the rebuild handed the task, and otherwise the overlay captured before the switch.
Covered on both rejecting legs: the provider-settings leg, where both existing cases now
assert the reported name against the reported settings, and the pin leg, added as its own
case. Without the restore the three assertions fail (38/41); with it 41/41, and the
ClineProvider, sticky-profile, sticky-mode, parallelMode, webviewMessageHandler,
api-configuration, ContextProxy and registerCommands suites pass unchanged.1 parent cf80e4b commit 1971923
2 files changed
Lines changed: 119 additions & 16 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3779 | 3779 | | |
3780 | 3780 | | |
3781 | 3781 | | |
3782 | | - | |
3783 | | - | |
3784 | | - | |
3785 | | - | |
3786 | | - | |
3787 | | - | |
3788 | | - | |
3789 | | - | |
3790 | | - | |
3791 | | - | |
3792 | | - | |
3793 | | - | |
3794 | | - | |
3795 | | - | |
3796 | | - | |
| 3782 | + | |
| 3783 | + | |
| 3784 | + | |
| 3785 | + | |
| 3786 | + | |
| 3787 | + | |
| 3788 | + | |
| 3789 | + | |
| 3790 | + | |
| 3791 | + | |
| 3792 | + | |
| 3793 | + | |
| 3794 | + | |
| 3795 | + | |
| 3796 | + | |
| 3797 | + | |
| 3798 | + | |
| 3799 | + | |
| 3800 | + | |
| 3801 | + | |
| 3802 | + | |
| 3803 | + | |
| 3804 | + | |
| 3805 | + | |
| 3806 | + | |
3797 | 3807 | | |
3798 | 3808 | | |
3799 | 3809 | | |
| |||
3802 | 3812 | | |
3803 | 3813 | | |
3804 | 3814 | | |
3805 | | - | |
| 3815 | + | |
| 3816 | + | |
| 3817 | + | |
| 3818 | + | |
| 3819 | + | |
| 3820 | + | |
| 3821 | + | |
| 3822 | + | |
| 3823 | + | |
| 3824 | + | |
| 3825 | + | |
| 3826 | + | |
| 3827 | + | |
3806 | 3828 | | |
3807 | 3829 | | |
3808 | 3830 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1077 | 1077 | | |
1078 | 1078 | | |
1079 | 1079 | | |
| 1080 | + | |
| 1081 | + | |
| 1082 | + | |
| 1083 | + | |
| 1084 | + | |
| 1085 | + | |
| 1086 | + | |
| 1087 | + | |
| 1088 | + | |
| 1089 | + | |
| 1090 | + | |
1080 | 1091 | | |
1081 | 1092 | | |
1082 | 1093 | | |
| |||
1126 | 1137 | | |
1127 | 1138 | | |
1128 | 1139 | | |
| 1140 | + | |
| 1141 | + | |
| 1142 | + | |
| 1143 | + | |
| 1144 | + | |
| 1145 | + | |
| 1146 | + | |
| 1147 | + | |
| 1148 | + | |
| 1149 | + | |
| 1150 | + | |
| 1151 | + | |
| 1152 | + | |
| 1153 | + | |
| 1154 | + | |
| 1155 | + | |
| 1156 | + | |
| 1157 | + | |
| 1158 | + | |
| 1159 | + | |
| 1160 | + | |
| 1161 | + | |
| 1162 | + | |
| 1163 | + | |
| 1164 | + | |
| 1165 | + | |
| 1166 | + | |
| 1167 | + | |
| 1168 | + | |
| 1169 | + | |
| 1170 | + | |
| 1171 | + | |
| 1172 | + | |
| 1173 | + | |
| 1174 | + | |
| 1175 | + | |
| 1176 | + | |
| 1177 | + | |
| 1178 | + | |
| 1179 | + | |
| 1180 | + | |
| 1181 | + | |
| 1182 | + | |
| 1183 | + | |
| 1184 | + | |
| 1185 | + | |
| 1186 | + | |
| 1187 | + | |
| 1188 | + | |
| 1189 | + | |
| 1190 | + | |
| 1191 | + | |
| 1192 | + | |
| 1193 | + | |
| 1194 | + | |
| 1195 | + | |
| 1196 | + | |
| 1197 | + | |
| 1198 | + | |
| 1199 | + | |
| 1200 | + | |
| 1201 | + | |
| 1202 | + | |
| 1203 | + | |
| 1204 | + | |
| 1205 | + | |
| 1206 | + | |
| 1207 | + | |
| 1208 | + | |
| 1209 | + | |
1129 | 1210 | | |
1130 | 1211 | | |
1131 | 1212 | | |
| |||
0 commit comments