@@ -5,9 +5,14 @@ tone_instructions: >-
55 Prioritize correctness, security, data loss, lifecycle, and regressions; avoid speculative style
66 comments and unrelated refactors.
77
8+ chat :
9+ allow_non_org_members : true
10+
811knowledge_base :
912 web_search :
1013 enabled : true
14+ learnings :
15+ scope : local
1116
1217reviews :
1318 profile : assertive
@@ -24,6 +29,7 @@ reviews:
2429 enabled : false
2530 drafts : false
2631 auto_incremental_review : true
32+ auto_pause_after_reviewed_commits : 0
2733 labels :
2834 - " coderabbit-review-active"
2935
@@ -42,21 +48,31 @@ reviews:
4248 instructions : >-
4349 Act as an adversarial second-opinion reviewer. Verify PR claims against implementation and
4450 contracts. Trace changed inputs through normal, boundary, error, cancellation, retry, and
45- default paths and their consumers. Seek plausible counterexamples and regressions from removed
46- safeguards. Identify assumptions in changed code that depend on facts outside the diff. First
47- verify repository conventions, tests, and related implementations. When a potential finding
48- depends on external behavior, use web search and prefer official documentation, specifications,
49- or upstream repositories. Report only concrete, actionable conflicts or failure modes, citing
50- the relevant repository location or external source. Prioritize correctness, security, data loss,
51- lifecycle, and test gaps. Do not report generic best practices, unsupported concerns, speculative
52- style comments, or unrelated refactors. Search for existing helpers before suggesting abstractions.
51+ default paths and their direct test counterparts. Do not flag defects in files not changed by
52+ this PR unless the defect is directly triggered by changed code and cannot be detected in the
53+ changed file alone. Seek plausible counterexamples and regressions from removed safeguards.
54+ Identify assumptions in changed code that depend on facts outside the diff. First verify
55+ repository conventions, tests, and related implementations. When a potential finding depends on
56+ external behavior, use web search and prefer official documentation, specifications, or upstream
57+ repositories. Report only concrete, actionable conflicts or failure modes, citing the relevant
58+ repository location or external source. Prioritize correctness, security, data loss, lifecycle, and
59+ test gaps. Do not report generic best practices, unsupported concerns, speculative style
60+ comments, or unrelated refactors. When changed code introduces a local implementation of a
61+ cross-cutting concern, check whether it bypasses or duplicates an established repository
62+ abstraction or nearby convention. Report only a concrete inconsistency with behavioral or
63+ maintenance impact, and allow intentional deviations. Treat the linked issue and this PR
64+ description as the scope boundary. When a confirmed defect needs work beyond that boundary
65+ and this PR does not create the hazard, do not request changes for it. List it once in the
66+ walkthrough under follow-up candidates, with one line for the trigger.
5367
5468 - path : " **/*.{ts,tsx,js,jsx,mts,mjs,cts,cjs}"
5569 instructions : >-
5670 Check strict typing and exhaustive behavior across normal, boundary, error,
5771 cancellation, retry, and compatibility paths. Verify promises and errors are handled,
5872 existing helpers are reused, and new code introduces no `any`, unjustified double
5973 assertions, floating promises, duplicated helpers, or increased lint suppressions.
74+ When a refactor adds early-return guards that redirect a subset of inputs to a new
75+ code path, confirm the old branches for those inputs are removed or unreachable.
6076
6177 - path : " {**/*.{test,spec}.{ts,tsx,js,jsx},**/__tests__/**}"
6278 instructions : >-
@@ -72,6 +88,11 @@ reviews:
7288 Flag tests that assert in-flight behavior only after the call completes — these cannot
7389 prove the behavior fires during execution. Check that describe block names match the
7490 actual subjects of the tests they contain.
91+ For tests that assert only mock call counts, confirm a corresponding return-value
92+ assertion exists; a regression that silently returns stale fallback data can satisfy
93+ a call-count check. For code with fallback behavior, verify both the cold-start case
94+ (no prior state) and the warm case (prior state exists) are covered, as they exercise
95+ different branches.
7596
7697 - path : " apps/vscode-e2e/**"
7798 instructions : >-
@@ -111,6 +132,9 @@ reviews:
111132 Check persistence and lifecycle invariants: awaited atomic writes, rollback or explicit
112133 partial-failure behavior, cross-window state consistency, stale listeners/watchers,
113134 cancellation, idempotency, and safe restart/resume without lost or duplicated state.
135+ For async functions that read shared mutable state before an `await` and write it back
136+ after, verify the captured reference is still valid when the write executes; a concurrent
137+ mutation during the await can cause a stale snapshot to overwrite a newer state.
114138
115139 - path : " .github/**"
116140 instructions : >-
@@ -124,7 +148,20 @@ reviews:
124148 during release preparation. Verify documentation describes real behavior and contracts,
125149 and deprioritize prose-only nits that do not affect correctness or usability.
126150
151+ finishing_touches :
152+ docstrings :
153+ enabled : false
154+
127155 pre_merge_checks :
156+ override_requested_reviewers_only : true
157+ docstrings :
158+ mode : off
159+ title :
160+ mode : warning
161+ description :
162+ mode : warning
163+ issue_assessment :
164+ mode : error
128165 custom_checks :
129166 - name : Regression evidence
130167 mode : warning
@@ -135,18 +172,32 @@ reviews:
135172 snapshot. Do not demand tests for unchanged behavior, mechanical configuration, or every
136173 branch without a plausible regression scenario. Cite the changed behavior and missing
137174 evidence.
138- - name : Trust and persistence invariants
175+ - name : Security boundaries
176+ mode : error
177+ instructions : >-
178+ Fail only when a concrete changed path leaks secrets or PII, trusts or executes
179+ unvalidated input, or bypasses approval or allowlist controls. Cite the changed path
180+ and a plausible triggering scenario; pass when no such changed path exists.
181+ - name : Persistence integrity
139182 mode : error
140183 instructions : >-
141- Fail only for a concrete changed path that leaks secrets or PII, trusts or executes
142- unvalidated input, bypasses approval or allowlist controls, can lose persisted state due
143- to a missing await, non-atomic write, or omitted default propagation, or leaks lifecycle
144- resources. Cite the path and a plausible triggering scenario; pass when no such changed
145- path exists.
184+ Fail only when a concrete changed persistence path can lose or corrupt state because an
185+ operation is not awaited, a write is non-atomic, rollback or explicit partial-failure
186+ behavior is missing, or a persisted default is not propagated to a consumer. Cite the
187+ changed path and a plausible triggering scenario; pass when no such changed path exists.
188+ - name : Lifecycle resource cleanup
189+ mode : warning
190+ instructions : >-
191+ Fail only when a concrete changed lifecycle path can leak a listener, watcher, provider,
192+ timer, task, or other resource, or can duplicate work after cancellation, disposal, or
193+ restart. Cite the changed path and a plausible triggering scenario; pass when no such
194+ changed path exists.
146195
147196 tools :
148197 eslint :
149198 enabled : true
199+ github-checks :
200+ enabled : true
150201 actionlint :
151202 enabled : true
152203 shellcheck :
0 commit comments