Skip to content

Commit 18095c9

Browse files
committed
Merge upstream/main into fix/issue-1415-stray-tab-system-prompt
Apply the stray-tab fix onto the restructured prompt builder: getToolUseGuidelinesSection now takes the effective tool policy, and the guidelines template keeps the fix (heading starts at column 0). Snapshots and the column-0 regression assertion auto-merge cleanly.
2 parents 0432577 + 7c291bb commit 18095c9

438 files changed

Lines changed: 35842 additions & 2970 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎.coderabbit.yaml‎

Lines changed: 65 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,14 @@ tone_instructions: >-
55
Prioritize correctness, security, data loss, lifecycle, and regressions; avoid speculative style
66
comments and unrelated refactors.
77
8+
chat:
9+
allow_non_org_members: true
10+
811
knowledge_base:
912
web_search:
1013
enabled: true
14+
learnings:
15+
scope: local
1116

1217
reviews:
1318
profile: assertive
@@ -24,6 +29,7 @@ reviews:
2429
enabled: false
2530
drafts: false
2631
auto_incremental_review: true
32+
auto_pause_after_reviewed_commits: 0
2733
labels:
2834
- "coderabbit-review-active"
2935

@@ -42,21 +48,31 @@ reviews:
4248
instructions: >-
4349
Act as an adversarial second-opinion reviewer. Verify PR claims against implementation and
4450
contracts. Trace changed inputs through normal, boundary, error, cancellation, retry, and
45-
default paths and their consumers. Seek plausible counterexamples and regressions from removed
46-
safeguards. Identify assumptions in changed code that depend on facts outside the diff. First
47-
verify repository conventions, tests, and related implementations. When a potential finding
48-
depends on external behavior, use web search and prefer official documentation, specifications,
49-
or upstream repositories. Report only concrete, actionable conflicts or failure modes, citing
50-
the relevant repository location or external source. Prioritize correctness, security, data loss,
51-
lifecycle, and test gaps. Do not report generic best practices, unsupported concerns, speculative
52-
style comments, or unrelated refactors. Search for existing helpers before suggesting abstractions.
51+
default paths and their direct test counterparts. Do not flag defects in files not changed by
52+
this PR unless the defect is directly triggered by changed code and cannot be detected in the
53+
changed file alone. Seek plausible counterexamples and regressions from removed safeguards.
54+
Identify assumptions in changed code that depend on facts outside the diff. First verify
55+
repository conventions, tests, and related implementations. When a potential finding depends on
56+
external behavior, use web search and prefer official documentation, specifications, or upstream
57+
repositories. Report only concrete, actionable conflicts or failure modes, citing the relevant
58+
repository location or external source. Prioritize correctness, security, data loss, lifecycle, and
59+
test gaps. Do not report generic best practices, unsupported concerns, speculative style
60+
comments, or unrelated refactors. When changed code introduces a local implementation of a
61+
cross-cutting concern, check whether it bypasses or duplicates an established repository
62+
abstraction or nearby convention. Report only a concrete inconsistency with behavioral or
63+
maintenance impact, and allow intentional deviations. Treat the linked issue and this PR
64+
description as the scope boundary. When a confirmed defect needs work beyond that boundary
65+
and this PR does not create the hazard, do not request changes for it. List it once in the
66+
walkthrough under follow-up candidates, with one line for the trigger.
5367
5468
- path: "**/*.{ts,tsx,js,jsx,mts,mjs,cts,cjs}"
5569
instructions: >-
5670
Check strict typing and exhaustive behavior across normal, boundary, error,
5771
cancellation, retry, and compatibility paths. Verify promises and errors are handled,
5872
existing helpers are reused, and new code introduces no `any`, unjustified double
5973
assertions, floating promises, duplicated helpers, or increased lint suppressions.
74+
When a refactor adds early-return guards that redirect a subset of inputs to a new
75+
code path, confirm the old branches for those inputs are removed or unreachable.
6076
6177
- path: "{**/*.{test,spec}.{ts,tsx,js,jsx},**/__tests__/**}"
6278
instructions: >-
@@ -72,6 +88,11 @@ reviews:
7288
Flag tests that assert in-flight behavior only after the call completes — these cannot
7389
prove the behavior fires during execution. Check that describe block names match the
7490
actual subjects of the tests they contain.
91+
For tests that assert only mock call counts, confirm a corresponding return-value
92+
assertion exists; a regression that silently returns stale fallback data can satisfy
93+
a call-count check. For code with fallback behavior, verify both the cold-start case
94+
(no prior state) and the warm case (prior state exists) are covered, as they exercise
95+
different branches.
7596
7697
- path: "apps/vscode-e2e/**"
7798
instructions: >-
@@ -111,6 +132,9 @@ reviews:
111132
Check persistence and lifecycle invariants: awaited atomic writes, rollback or explicit
112133
partial-failure behavior, cross-window state consistency, stale listeners/watchers,
113134
cancellation, idempotency, and safe restart/resume without lost or duplicated state.
135+
For async functions that read shared mutable state before an `await` and write it back
136+
after, verify the captured reference is still valid when the write executes; a concurrent
137+
mutation during the await can cause a stale snapshot to overwrite a newer state.
114138
115139
- path: ".github/**"
116140
instructions: >-
@@ -124,7 +148,20 @@ reviews:
124148
during release preparation. Verify documentation describes real behavior and contracts,
125149
and deprioritize prose-only nits that do not affect correctness or usability.
126150
151+
finishing_touches:
152+
docstrings:
153+
enabled: false
154+
127155
pre_merge_checks:
156+
override_requested_reviewers_only: true
157+
docstrings:
158+
mode: off
159+
title:
160+
mode: warning
161+
description:
162+
mode: warning
163+
issue_assessment:
164+
mode: error
128165
custom_checks:
129166
- name: Regression evidence
130167
mode: warning
@@ -135,18 +172,32 @@ reviews:
135172
snapshot. Do not demand tests for unchanged behavior, mechanical configuration, or every
136173
branch without a plausible regression scenario. Cite the changed behavior and missing
137174
evidence.
138-
- name: Trust and persistence invariants
175+
- name: Security boundaries
176+
mode: error
177+
instructions: >-
178+
Fail only when a concrete changed path leaks secrets or PII, trusts or executes
179+
unvalidated input, or bypasses approval or allowlist controls. Cite the changed path
180+
and a plausible triggering scenario; pass when no such changed path exists.
181+
- name: Persistence integrity
139182
mode: error
140183
instructions: >-
141-
Fail only for a concrete changed path that leaks secrets or PII, trusts or executes
142-
unvalidated input, bypasses approval or allowlist controls, can lose persisted state due
143-
to a missing await, non-atomic write, or omitted default propagation, or leaks lifecycle
144-
resources. Cite the path and a plausible triggering scenario; pass when no such changed
145-
path exists.
184+
Fail only when a concrete changed persistence path can lose or corrupt state because an
185+
operation is not awaited, a write is non-atomic, rollback or explicit partial-failure
186+
behavior is missing, or a persisted default is not propagated to a consumer. Cite the
187+
changed path and a plausible triggering scenario; pass when no such changed path exists.
188+
- name: Lifecycle resource cleanup
189+
mode: warning
190+
instructions: >-
191+
Fail only when a concrete changed lifecycle path can leak a listener, watcher, provider,
192+
timer, task, or other resource, or can duplicate work after cancellation, disposal, or
193+
restart. Cite the changed path and a plausible triggering scenario; pass when no such
194+
changed path exists.
146195
147196
tools:
148197
eslint:
149198
enabled: true
199+
github-checks:
200+
enabled: true
150201
actionlint:
151202
enabled: true
152203
shellcheck:

‎.github/CODEOWNERS‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
# These owners will be the default owners for everything in the repo
2-
* @taltas @JamesRobert20 @navedmerchant @hannesrudolph @edelauna
2+
* @taltas @JamesRobert20 @navedmerchant @edelauna

‎.github/actions/setup-node-pnpm/action.yml‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,22 +24,22 @@ runs:
2424
using: "composite"
2525
steps:
2626
- name: Install pnpm
27-
uses: pnpm/action-setup@b906affcce14559ad1aafd4ab0e942779e9f58b1 # v4
27+
uses: pnpm/action-setup@0977fd99725f1db4007ccb2928dbb4e90d06cc86 # v6.0.10
2828
with:
2929
version: ${{ inputs.pnpm-version }}
3030
- name: Get pnpm store directory
3131
shell: bash
3232
run: |
3333
echo "STORE_PATH=$(pnpm store path --silent)" >> $GITHUB_ENV
3434
- name: Setup pnpm cache
35-
uses: actions/cache@0057852bfaa89a56745cba8c7296529d2fc39830 # v4
35+
uses: actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
3636
with:
3737
path: ${{ env.STORE_PATH }}
3838
key: ${{ runner.os }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }}
3939
restore-keys: |
4040
${{ runner.os }}-pnpm-store-
4141
- name: Setup Node.js
42-
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4
42+
uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
4343
with:
4444
node-version: ${{ inputs.node-version }}
4545
- name: Install dependencies

‎.github/workflows/cli-release.yml‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ jobs:
3939

4040
steps:
4141
- name: Checkout code
42-
uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4
42+
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
4343
with:
4444
fetch-depth: 0
4545

@@ -200,7 +200,7 @@ jobs:
200200
rm -rf "$VERIFY_DIR"
201201
202202
- name: Upload artifact
203-
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4
203+
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
204204
with:
205205
name: cli-${{ matrix.platform }}
206206
path: |
@@ -218,7 +218,7 @@ jobs:
218218

219219
steps:
220220
- name: Checkout code
221-
uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4
221+
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
222222

223223
- name: Get version
224224
id: version
@@ -232,7 +232,7 @@ jobs:
232232
echo "tag=cli-v$VERSION" >> $GITHUB_OUTPUT
233233
234234
- name: Download all artifacts
235-
uses: actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093 # v4
235+
uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1
236236
with:
237237
path: artifacts
238238

@@ -378,7 +378,7 @@ jobs:
378378

379379
steps:
380380
- name: Download all artifacts
381-
uses: actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093 # v4
381+
uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1
382382
with:
383383
path: artifacts
384384

0 commit comments

Comments
 (0)