Repository navigation
Commit 17890eb
committed
#1560 settled the profile-write plumbing this unit extends, so this head carries
that plumbing plus this unit's cross-instance behaviour, resolved file by file.
Hand-resolved files:
- src/core/webview/ClineProvider.ts: kept main's write machinery - the
previousManagerGate/getSelectionAndModeConfigs snapshot with its id-gated restore,
the hasConfig fail-closed classification of a rejected profile read, the
name-and-id deleteConfig, the launch invalid-pin repair ordering, main's
displaySettings fields read through this unit's merged overlay copy, and main's
settled dispose() cleanup tail with its loadViewState reload - and kept this
unit's cross-instance machinery beside it: the runExclusiveAcrossInstances join
around the store write, the sibling overlay snapshot with its commit-time pin
recheck and its fail-closed refusal to overwrite the shared store, the sibling
postState guards with their named logs, modeSlugResolves, preserveForeignTask,
and the boolean-returning loadViewState delivery seam annotated at both ends.
- src/core/webview/webviewMessageHandler.ts: kept main's launch repair (an
unresolvable view profile re-pins only this view through the durable writes when
the shared selection is still valid) and main's mode-slug validation surface, and
kept this unit's cross-instance section around the profile save and the rename
compensation that depends on it.
- src/core/webview/__tests__/webviewMessageHandler.spec.ts: kept main's launch
tests, which assert that re-pin contract, and retired this unit's two
activation-based variants that the repair replaced; the launch fixture carries
main's activateProviderProfile signature with this unit's activate options.
- src/core/webview/ClineProvider.spec.ts: union of both suites. This unit's rival
double gained the read-back getProfile the writer now performs so the
critical-section ordering test still exercises the save inside the section.
Five of this unit's tests were retired as superseded by main's counterparts: the
two that asserted dispose rejecting on a failing cleanup step (main's tail runs
every later step and reports the failure) and the one that expected an unset
view-profile provider to default to Anthropic rather than follow the shared
selection.
- src/core/webview/__tests__/ClineProvider.parallelMode.spec.ts: the two
registrations of the manager mock now form one double carrying main's gate
(getSelectionAndModeConfigs, hasConfig, gate-backed activation) and this unit's
cross-instance section, exporting the manager's typed not-found class with a
declared fallback because the original-module import can hand back a partially
initialized module for this chain. Main's re-point and replacement-activation
bodies won their titles; this unit's sibling-overlay guard tests stayed; main's
log-and-continue variant was retired as the guard replaces its outcome and the
abort test keeps that coverage; and a deleted profile lookup now rejects with the
manager's own ProviderSettingsNotFoundError, as ProviderSettingsManager.getProfile
does, so a stale pin is not mistaken for a store outage.
- src/activate/registerCommands.ts and its spec: took main's reviewed superset
(the postActions helper, the tab-priority focus panel post, the
all-instances-aware diagnostics handler); this unit's only own content there was
the pre-refactor inline post forms main's helper supersedes, and this unit's
all-instances diagnostics test was ported onto main's handler shape with its
module mock.
- src/extension/api.ts, its configuration spec, and the webview-ui api spec: main's
versions wholesale; the set-configuration spec keeps this unit's five lines beside
main'sseventeen additions.
- src/eslint-suppressions.json: the provider spec's any-suppressions pruned 191 to
188 after the retirements, proved with --prune-suppressions; no count increased.
- .gitignore: main's scratch-file ignore entries.
Verified: tsc clean; eslint --max-warnings=0 clean on every merged path with no new
suppressions; prettier --check clean; 1008 tests across the affected suites green
(api-configuration, api-set-configuration, registerCommands, ContextProxy,
ProviderSettingsManager, ClineProvider, parallelMode, apiHandlerRebuild,
webviewMessageHandler, sticky-mode, sticky-profile, Task.sticky-profile-race).
124 files changed
Lines changed: 12886 additions & 988 deletions
File tree
- .github/workflows
- apps/vscode-e2e
- src/visual
- __screenshots__
- docs
- packages
- config-eslint
- types/src
- scripts
- src
- activate
- __tests__
- api/providers
- __tests__
- utils
- __tests__
- assets/marketplace
- core
- config
- __tests__
- task/__tests__
- webview
- __tests__
- extension
- __tests__
- services/tools
- __tests__
- test-utils
- webview-ui
- playwright/gallery
- src
- __tests__
- components
- chat
- __tests__
- __screenshots__
- history
- __tests__
- settings
- __tests__
- __screenshots__
- context
- i18n
- __tests__
- locales
- ca
- de
- en
- es
- fr
- hi
- id
- it
- ja
- ko
- nl
- pl
- pt-BR
- ru
- tr
- vi
- zh-CN
- zh-TW
- utils
- __tests__
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
12 | 18 | | |
13 | 19 | | |
14 | 20 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
10 | 16 | | |
11 | 17 | | |
12 | 18 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
10 | 16 | | |
11 | 17 | | |
12 | 18 | | |
| |||
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
50 | 50 | | |
51 | 51 | | |
52 | 52 | | |
| 53 | + | |
53 | 54 | | |
54 | 55 | | |
55 | 56 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
19 | 25 | | |
20 | 26 | | |
21 | 27 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
62 | 62 | | |
63 | 63 | | |
64 | 64 | | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
9 | | - | |
| 8 | + | |
| 9 | + | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
| 12 | + | |
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
89 | 89 | | |
90 | 90 | | |
91 | 91 | | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
92 | 105 | | |
93 | | - | |
| 106 | + | |
94 | 107 | | |
95 | 108 | | |
96 | 109 | | |
| |||
0 commit comments