Repository navigation
Commit 0dc92ca
easonLiangWorldedtech
fix(tools): do not report a completed teardown when the diff revert fails
onParameterParseFailure() tore down the per-task stream state first, then reverted the diff document with the
failure logged and swallowed, then reset the diff provider. A failed revert therefore looked like a completed
teardown even though the editor can still hold the unapproved partial content - and a user save of that editor
lands a write the task never approved, with nothing in the UI saying so.
The revert now runs while the recovery state still exists, revertDiffChangesBeforeReset returns whether it
succeeded, and a failed revert is surfaced with task.say("error", ...) naming the hazard. The remaining cleanup
(reset + per-task teardown) still runs, so the task is never left half-torn-down.
Test: the seeded per-task state is observed from inside the failing revertChanges double, so the ordering is
pinned (state present during rollback, gone afterwards), and the error say is asserted. Without the fix the
test fails (1 failed / 5 passed); with it 6 pass.
The streaming-failure cleanup keeps its existing log-only behaviour: that path's error is reported by the
authoritative non-partial block in execute(), as its comment states, so adding a second message there would
double-report the same failure.
Local: writeToFileTool-partial-state-cleanup.spec.ts 6 passed, eslint clean with --prune-suppressions (no
suppression change), package tsc clean.1 parent b04e224 commit 0dc92ca
2 files changed
Lines changed: 62 additions & 10 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
144 | 144 | | |
145 | 145 | | |
146 | 146 | | |
147 | | - | |
148 | | - | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
149 | 151 | | |
150 | | - | |
151 | | - | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
152 | 157 | | |
153 | | - | |
| 158 | + | |
| 159 | + | |
154 | 160 | | |
155 | 161 | | |
156 | 162 | | |
| |||
179 | 185 | | |
180 | 186 | | |
181 | 187 | | |
182 | | - | |
183 | 188 | | |
184 | 189 | | |
185 | 190 | | |
186 | 191 | | |
187 | | - | |
188 | | - | |
189 | | - | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
190 | 198 | | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
191 | 208 | | |
192 | 209 | | |
193 | 210 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
| 22 | + | |
22 | 23 | | |
23 | 24 | | |
24 | 25 | | |
| |||
32 | 33 | | |
33 | 34 | | |
34 | 35 | | |
| 36 | + | |
35 | 37 | | |
36 | 38 | | |
37 | 39 | | |
| |||
87 | 89 | | |
88 | 90 | | |
89 | 91 | | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
90 | 125 | | |
91 | | - | |
| 126 | + | |
92 | 127 | | |
93 | 128 | | |
94 | 129 | | |
| |||
0 commit comments