Repository navigation
Commit 0867de6
committed
test(gemini-format): snapshot input in closeDanglingFunctionCalls no-op tests
What: In the two 'unchanged' tests, structuredClone the input contents
before calling closeDanglingFunctionCalls and assert both the returned
value and the input against that pre-call snapshot.
Why: The helper mutates its input array in place and returns the same
reference, so comparing the result to the (already mutated) input array
was a self-comparison that could never fail, even if the helper appended
an unwanted turn (CodeRabbit review on PR #1753).
Impact: The no-op tests now genuinely pin 'no turn appended, input
unmodified'; all synthesis assertions kept unchanged.1 parent 9718cb8 commit 0867de6
1 file changed
Lines changed: 13 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
729 | 729 | | |
730 | 730 | | |
731 | 731 | | |
| 732 | + | |
| 733 | + | |
| 734 | + | |
| 735 | + | |
732 | 736 | | |
733 | | - | |
| 737 | + | |
| 738 | + | |
| 739 | + | |
| 740 | + | |
734 | 741 | | |
735 | 742 | | |
736 | 743 | | |
| |||
749 | 756 | | |
750 | 757 | | |
751 | 758 | | |
| 759 | + | |
| 760 | + | |
| 761 | + | |
752 | 762 | | |
753 | | - | |
| 763 | + | |
| 764 | + | |
754 | 765 | | |
755 | 766 | | |
0 commit comments