Skip to content

Commit 0503002

Browse files
committed
revert(ci): restore workspace install in the translation check
1 parent c843ea5 commit 0503002

2 files changed

Lines changed: 3 additions & 9 deletions

File tree

‎.github/workflows/code-qa.yml‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -70,12 +70,10 @@ jobs:
7070
steps:
7171
- name: Checkout code
7272
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
73-
# find-missing-translations.js uses Node built-ins only, so the
74-
# pinned Node setup is kept but no workspace install is needed.
7573
- name: Setup Node.js and pnpm
7674
uses: ./.github/actions/setup-node-pnpm
7775
with:
78-
skip-install: true
76+
install-args: "--frozen-lockfile"
7977
- name: Verify all translations are complete
8078
run: node scripts/find-missing-translations.js
8179
- name: Verify t() calls pass every interpolation variable

‎scripts/code-qa-workflow.test.mjs‎

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -138,17 +138,13 @@ describe("Knip quality gate", () => {
138138
})
139139

140140
describe("Code QA dependency install", () => {
141-
it("installs every job with a frozen lockfile unless the translation check skips installation", () => {
141+
it("installs every job with a frozen lockfile", () => {
142142
const setups = workflow.match(/uses: \.\/\.github\/actions\/setup-node-pnpm\n/g) ?? []
143143
const frozen =
144144
workflow.match(
145145
/uses: \.\/\.github\/actions\/setup-node-pnpm\n\s+with:\n\s+install-args: "--frozen-lockfile"\n/g,
146146
) ?? []
147-
const skipped =
148-
workflow.match(/uses: \.\/\.github\/actions\/setup-node-pnpm\n\s+with:\n\s+skip-install: true\n/g) ?? []
149147
assert.ok(setups.length > 0, "missing setup-node-pnpm steps")
150-
assert.equal(frozen.length + skipped.length, setups.length)
151-
assert.equal(skipped.length, 1)
152-
assert.match(workflow, /check-translations:[\s\S]*?skip-install: true/)
148+
assert.equal(frozen.length, setups.length)
153149
})
154150
})

0 commit comments

Comments
 (0)