Repository navigation
Commit 036245c
* fix(task): stage-independent saveClineMessages + finalize open partial tool ask
* test(task): stop leaking the fixed-task-id record between save-stage tests
The task uuid is mocked to a fixed value, so the ui_messages.json this save writes outlives the test that
created it. The sibling test below removes the whole directory and recreates it, which is the only reason
the leak has not surfaced: with merge = true, any later save that reads its merged output would fold in a
stale record and fail by run order rather than by behavior.
The body now runs in try/finally, removing ui_messages.json and restoring both spies whatever the
assertions do. The spies moved out of the try so the finally can see them.
Local run: 162 passed in Task.spec.ts (the one remaining failure, blocks a truncated write_to_file call
instead of executing it, fails identically at cf5abe6 without this change - local artifact), eslint
clean, no suppression change.
* test(task): check the saved payload in finalizePartialToolAsk test
* chore(ci): request a fresh run for the flaky restart-persistence step
No code change. This empty commit exists only to obtain a new CI run, because the required e2e-mock check is red at c4ca658 and the failed job cannot be re-run with the token available here (POST /repos/Zoo-Code-Org/Zoo-Code/actions/runs/37880099804/rerun-failed-jobs -> 403 Must have admin rights to Repository).
Why the red is not caused by this branch:
- In job 113657575830, step 14 'Run mocked E2E tests' = success; only step 15 'Run mocked restart-persistence E2E test' failed. The create phase passed ('persists completed task across a fresh extension host', 1 passing); the verify phase threw TaskMessagesReadError: Failed to read task messages for 01a11ec0-9f7e-72db-9721-1c8b2d4d28f4 at /tmp/roo from readTaskMessages <- Task.resumeTaskFromHistory <- TaskScheduler.schedule, then 'Error: Timeout after 30s' (out/suite/utils.js:15).
- The previous head on this same branch, cf9206a, passed both steps (run 37516254245, 2026-10-06). The only commit between cf9206a and c4ca658 changes src/core/task/__tests__/Task.spec.ts (+13/-2), a Vitest unit-test file the mocked E2E suite never loads; no production file changed and the branch base is unchanged (7214352).
- The identical signature appears on unrelated branches: run 37762259575 (vps2-f2c), run 37706659841 (feat/chat-input-model-selector, same TaskMessagesReadError), run 37626907243 (feat/dte-v2-3-task-runtime-effort).
- Four sibling PRs carrying the same U1 Task.ts content passed this step: #1929 run 37873787271, #1928 run 37854340884, #1931 run 37833581055, #1932 run 37774292614.
Evidence note on the PR: #1927 (comment)
---------
Co-authored-by: easonLiangWorldedtech <[email protected]>
Co-authored-by: Elliott de Launay <[email protected]>
1 parent fc1fc9a commit 036245c
3 files changed
Lines changed: 495 additions & 5 deletions
File tree
- src/core
- assistant-message/__tests__
- task
- __tests__
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
89 | 89 | | |
90 | 90 | | |
91 | 91 | | |
| 92 | + | |
92 | 93 | | |
93 | 94 | | |
94 | 95 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
68 | 68 | | |
69 | 69 | | |
70 | 70 | | |
71 | | - | |
| 71 | + | |
72 | 72 | | |
73 | 73 | | |
74 | 74 | | |
| |||
1719 | 1719 | | |
1720 | 1720 | | |
1721 | 1721 | | |
1722 | | - | |
| 1722 | + | |
| 1723 | + | |
| 1724 | + | |
| 1725 | + | |
| 1726 | + | |
| 1727 | + | |
| 1728 | + | |
| 1729 | + | |
| 1730 | + | |
| 1731 | + | |
| 1732 | + | |
| 1733 | + | |
| 1734 | + | |
1723 | 1735 | | |
1724 | 1736 | | |
1725 | 1737 | | |
| |||
1728 | 1740 | | |
1729 | 1741 | | |
1730 | 1742 | | |
| 1743 | + | |
| 1744 | + | |
| 1745 | + | |
| 1746 | + | |
1731 | 1747 | | |
| 1748 | + | |
1732 | 1749 | | |
1733 | 1750 | | |
1734 | 1751 | | |
| |||
1756 | 1773 | | |
1757 | 1774 | | |
1758 | 1775 | | |
1759 | | - | |
1760 | 1776 | | |
1761 | | - | |
1762 | | - | |
| 1777 | + | |
| 1778 | + | |
| 1779 | + | |
| 1780 | + | |
1763 | 1781 | | |
| 1782 | + | |
| 1783 | + | |
1764 | 1784 | | |
1765 | 1785 | | |
1766 | 1786 | | |
| |||
2761 | 2781 | | |
2762 | 2782 | | |
2763 | 2783 | | |
| 2784 | + | |
| 2785 | + | |
| 2786 | + | |
| 2787 | + | |
| 2788 | + | |
| 2789 | + | |
| 2790 | + | |
| 2791 | + | |
| 2792 | + | |
| 2793 | + | |
| 2794 | + | |
| 2795 | + | |
| 2796 | + | |
| 2797 | + | |
| 2798 | + | |
| 2799 | + | |
| 2800 | + | |
| 2801 | + | |
| 2802 | + | |
| 2803 | + | |
| 2804 | + | |
| 2805 | + | |
| 2806 | + | |
| 2807 | + | |
| 2808 | + | |
| 2809 | + | |
| 2810 | + | |
| 2811 | + | |
| 2812 | + | |
| 2813 | + | |
| 2814 | + | |
| 2815 | + | |
| 2816 | + | |
| 2817 | + | |
| 2818 | + | |
| 2819 | + | |
| 2820 | + | |
| 2821 | + | |
| 2822 | + | |
| 2823 | + | |
| 2824 | + | |
| 2825 | + | |
| 2826 | + | |
| 2827 | + | |
| 2828 | + | |
| 2829 | + | |
| 2830 | + | |
| 2831 | + | |
| 2832 | + | |
| 2833 | + | |
2764 | 2834 | | |
2765 | 2835 | | |
2766 | 2836 | | |
| |||
0 commit comments