Repository navigation
Commit 032678d
committed
fix(safe-write-json): keep the published target across a post-commit durability error
The 08:21Z Persistence Integrity row asked for commit-state tracking
across the safeWriteText failure boundary. The observable behavior at
this head was already correct - the catch cleanup unlinks the staging
path, which the commit rename had consumed, and the ENOENT-tolerant
handler swallows the miss - but the target survived only by accident:
the unlink still fires at a path this write no longer owns, so a
concurrent writer that reuses the staging name between the rename and
the cleanup loses its temp file to this write's catch.
safeWriteJson now clears the staged path when safeWriteText reports
PostCommitDurabilityError: the rename landed, the staged path is the
published target's former name, and the durability error rethrows so
the write is never observed as a confirmed-durable success. Regression
test: the parent-directory fsync fails after the commit rename; the
target stays present with the new JSON and no unlink fires at the
consumed staging path. Negative control: removing the guard reddens
exactly that test. 114/119 with the file-safety suites (5 pre-existing
skips).1 parent cc84906 commit 032678d
2 files changed
Lines changed: 52 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
| 6 | + | |
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| |||
1102 | 1102 | | |
1103 | 1103 | | |
1104 | 1104 | | |
| 1105 | + | |
| 1106 | + | |
| 1107 | + | |
| 1108 | + | |
| 1109 | + | |
| 1110 | + | |
| 1111 | + | |
| 1112 | + | |
| 1113 | + | |
| 1114 | + | |
| 1115 | + | |
| 1116 | + | |
| 1117 | + | |
| 1118 | + | |
| 1119 | + | |
| 1120 | + | |
| 1121 | + | |
| 1122 | + | |
| 1123 | + | |
| 1124 | + | |
| 1125 | + | |
| 1126 | + | |
| 1127 | + | |
| 1128 | + | |
| 1129 | + | |
| 1130 | + | |
| 1131 | + | |
| 1132 | + | |
| 1133 | + | |
| 1134 | + | |
| 1135 | + | |
| 1136 | + | |
| 1137 | + | |
| 1138 | + | |
| 1139 | + | |
| 1140 | + | |
| 1141 | + | |
| 1142 | + | |
| 1143 | + | |
| 1144 | + | |
1105 | 1145 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| 8 | + | |
8 | 9 | | |
9 | 10 | | |
10 | 11 | | |
| |||
278 | 279 | | |
279 | 280 | | |
280 | 281 | | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
281 | 292 | | |
282 | 293 | | |
283 | 294 | | |
| |||
0 commit comments