Repository navigation
Commit 4aee32c
Python: Surface switch-case condition errors instead of routing to the default branch (microsoft#8490)
* Python: surface switch-case condition errors instead of routing to default
SwitchCaseEdgeGroup wrapped every case predicate in a bare `except Exception`
that only logged a warning, so a predicate that raised was treated exactly like
one that returned False: the message fell through to the default branch and the
workflow completed successfully. A broken routing predicate became silently
wrong routing rather than a visible failure.
This contradicted `Edge.should_route`, which documents that predicate errors are
deliberately allowed to surface "to avoid masking logic bugs", and made the
existing `FanOutEdgeRunner` error path (span status EXCEPTION, re-raise)
unreachable for switch-case groups, so the failures were missing from telemetry
too. The block was marked `# pragma: no cover`.
Also align `FanOutEdgeRunner` with `SingleEdgeRunner`, which checks
`_can_handle` before evaluating a condition: drop messages no target can handle
before running the selection function. Without this, removing the catch would
turn an undeliverable message into a raised AttributeError instead of a
type-mismatch drop.
Fixes microsoft#8489
Co-Authored-By: Claude Opus 5 <[email protected]>
* Python: drop target-mismatched messages before the fan-out selection function
The runner fans every message out to all of the source's edge runners and gathers
them with `gather_cancelling_siblings_on_error`. `FanOutEdgeRunner` checked
`message.target_id` only after running the selection function, so a message
addressed to an executor reached through a different edge still had this group's
selection function evaluated against it - and a raise there cancelled the sibling
runner that was actually delivering the message.
Check `message.target_id` against `_target_map` first and return
DROPPED_TARGET_MISMATCH, ahead of the `_can_handle` check, matching
`SingleEdgeRunner`, which checks the target and then `_can_handle` before
evaluating `Edge.should_route`.
Co-Authored-By: Claude Opus 5 <[email protected]>
---------
Co-authored-by: Claude Opus 5 <[email protected]>1 parent 38fbb7f commit 4aee32c
3 files changed
Lines changed: 136 additions & 5 deletions
File tree
- python/packages/core
- agent_framework/_workflows
- tests/workflow
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
863 | 863 | | |
864 | 864 | | |
865 | 865 | | |
866 | | - | |
867 | | - | |
868 | | - | |
869 | | - | |
870 | | - | |
| 866 | + | |
| 867 | + | |
| 868 | + | |
| 869 | + | |
| 870 | + | |
| 871 | + | |
871 | 872 | | |
872 | 873 | | |
873 | 874 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
255 | 255 | | |
256 | 256 | | |
257 | 257 | | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
258 | 281 | | |
259 | 282 | | |
260 | 283 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1389 | 1389 | | |
1390 | 1390 | | |
1391 | 1391 | | |
| 1392 | + | |
| 1393 | + | |
| 1394 | + | |
| 1395 | + | |
| 1396 | + | |
| 1397 | + | |
| 1398 | + | |
| 1399 | + | |
| 1400 | + | |
| 1401 | + | |
| 1402 | + | |
| 1403 | + | |
| 1404 | + | |
| 1405 | + | |
| 1406 | + | |
| 1407 | + | |
| 1408 | + | |
| 1409 | + | |
| 1410 | + | |
| 1411 | + | |
| 1412 | + | |
| 1413 | + | |
| 1414 | + | |
| 1415 | + | |
| 1416 | + | |
| 1417 | + | |
| 1418 | + | |
| 1419 | + | |
| 1420 | + | |
| 1421 | + | |
| 1422 | + | |
| 1423 | + | |
| 1424 | + | |
| 1425 | + | |
| 1426 | + | |
| 1427 | + | |
| 1428 | + | |
| 1429 | + | |
| 1430 | + | |
| 1431 | + | |
| 1432 | + | |
| 1433 | + | |
| 1434 | + | |
| 1435 | + | |
| 1436 | + | |
| 1437 | + | |
| 1438 | + | |
| 1439 | + | |
| 1440 | + | |
| 1441 | + | |
| 1442 | + | |
| 1443 | + | |
| 1444 | + | |
| 1445 | + | |
| 1446 | + | |
| 1447 | + | |
| 1448 | + | |
| 1449 | + | |
| 1450 | + | |
| 1451 | + | |
| 1452 | + | |
| 1453 | + | |
| 1454 | + | |
| 1455 | + | |
| 1456 | + | |
| 1457 | + | |
| 1458 | + | |
| 1459 | + | |
| 1460 | + | |
| 1461 | + | |
| 1462 | + | |
| 1463 | + | |
| 1464 | + | |
| 1465 | + | |
| 1466 | + | |
| 1467 | + | |
| 1468 | + | |
| 1469 | + | |
| 1470 | + | |
| 1471 | + | |
| 1472 | + | |
| 1473 | + | |
| 1474 | + | |
| 1475 | + | |
| 1476 | + | |
| 1477 | + | |
| 1478 | + | |
| 1479 | + | |
| 1480 | + | |
| 1481 | + | |
| 1482 | + | |
| 1483 | + | |
| 1484 | + | |
| 1485 | + | |
| 1486 | + | |
| 1487 | + | |
| 1488 | + | |
| 1489 | + | |
| 1490 | + | |
| 1491 | + | |
| 1492 | + | |
| 1493 | + | |
| 1494 | + | |
| 1495 | + | |
| 1496 | + | |
| 1497 | + | |
| 1498 | + | |
1392 | 1499 | | |
1393 | 1500 | | |
1394 | 1501 | | |
| |||
0 commit comments