Zclassic v2.0.6-1 #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes equivalent changes to bitcoin/bitcoin#9446
SetMerkleBranch was the only call underneath SyncTransaction that required the cs_main lock.
Fixes a Windows-specific compile bug introduced in zcash#4212. Closes zcash#4214.
Signed-off-by: cryptobubbles <[email protected]>
Previously only one PUSHDATA was allowed, needlessly limiting applications such as matching OP_RETURN contents with bloom filters that operate on a per-PUSHDATA level. Now any combination that passes IsPushOnly() is allowed, so long as the total size of the scriptPubKey is less than 42 bytes. (unchanged modulo non-minimal PUSHDATA encodings) Also, this fixes the odd bug where previously the PUSHDATA could be replaced by any single opcode, even sigops consuming opcodes such as CHECKMULTISIG. (20 sigops!) Signed-off-by: cryptobubbles <[email protected]>
Signed-off-by: cryptobubbles <[email protected]>
Signed-off-by: cryptobubbles <[email protected]>
Signed-off-by: cryptobubbles <[email protected]>
Signed-off-by: cryptobubbles <[email protected]>
VictorLux
approved these changes
Dec 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notable changes
Fix for CVE-2019-16930 and CVE-2019-17048
Included the fix for "Linking Anonymous Transactions via Remote Side-Channel Attacks"
Relay: Any sequence of pushdatas in OP_RETURN outputs now allowed
Previously OP_RETURN outputs with a payload were only relayed and mined if they had a single pushdata. This restriction has been lifted to allow any combination of data pushes and numeric constant opcodes (OP_1 to OP_16) after the OP_RETURN. The limit on OP_RETURN output size is now applied to the entire serialized scriptPubKey, 223 bytes by default. (the new 220 bytes default plus three bytes overhead)
Changelog
Fixes a Windows-specific compile bug
Increase the default setting for nMaxDatacarrierBytes to 223 bytes
Accept any sequence of PUSHDATAs in OP_RETURN outputs
Ignore exceptions when deserializing note plaintexts
Move mempool SyncWithWallets call into its own thread