|
13 | 13 | // - SampsonError(E, Vec3, Vec3) (depth-aware variant — divides by z+EPS |
14 | 14 | // before applying Sampson formula) |
15 | 15 | // |
16 | | -// Helpers that DID duplicate native (EssentialFromMotion, the Vec2 overload |
17 | | -// of SampsonError, HomographyError, FundamentalFromMotionAndCameras) were |
18 | | -// dropped in favor of colmap::EssentialMatrixFromPose, |
19 | | -// colmap::ComputeSquaredSampsonError, colmap::ComputeSquaredHomographyError, |
20 | | -// and colmap::FundamentalFromEssentialMatrix respectively. |
| 16 | +// Helpers that duplicated native were dropped: |
| 17 | +// - EssentialFromMotion -> use colmap::EssentialMatrixFromPose |
| 18 | +// (colmap/geometry/essential_matrix.h:83). Migrated callers in |
| 19 | +// image_pair_inliers_glomap.cc. |
| 20 | +// - SampsonError(E, Vec2, Vec2) -> use colmap::ComputeSquaredSampsonError |
| 21 | +// (colmap/geometry/essential_matrix.h:144) with .homogeneous() |
| 22 | +// conversion at the call site. Migrated callers in |
| 23 | +// image_pair_inliers_glomap.cc. |
| 24 | +// - HomographyError -> use colmap::ComputeSquaredHomographyError |
| 25 | +// (colmap/geometry/homography_matrix.h:110, note arg order is |
| 26 | +// (point1, point2, H)). Migrated callers in image_pair_inliers_glomap.cc. |
| 27 | +// - FundamentalFromMotionAndCameras was a 1-line wrapper with zero |
| 28 | +// call sites — pure dead-code delete (no migration needed). If a |
| 29 | +// future caller appears, build it inline as |
| 30 | +// ``FundamentalFromEssentialMatrix(K2, EssentialMatrixFromPose(pose), K1)`` |
| 31 | +// from colmap/geometry/essential_matrix.h. |
21 | 32 |
|
22 | 33 | namespace colmap { |
23 | 34 | namespace glomap_ra { |
|
0 commit comments