Closed
Conversation
Contributor
Author
|
This is very simple changes. We should try to find a easy way to sync properties with spark. It's a little bit time consuming job. |
Contributor
Author
|
Use this link for check real changes without indentations jongyoul/zeppelin@54fab52 |
Contributor
|
Indentation is 2spaces |
Contributor
Author
|
@anthonycorbacho Yes, I fixed indentation to 2 spaces. some lines was tab and 4spaces and so on... |
Contributor
Author
|
If I make a mistake, feel free to talk to me. |
Contributor
|
LGTM... |
Contributor
|
Thanks, LGTM! |
Contributor
Author
|
Could anyone please merge this PR? |
Contributor
|
We're in the middle of code transition to ASF. So i'm afraid we can not merge it right now. I'll discuss about it in the mailing list. |
Contributor
Author
|
@Leemoonsoo Ok. You have a plan to merge something after moving to ASF, don't you? |
jongyoul
added a commit
to jongyoul/zeppelin
that referenced
this pull request
Mar 25, 2015
- This PR is from ZEPL/zeppelin#394 - Fixed indentation with 2 spaces Signed-off-by: Jongyoul Lee <[email protected]>
Contributor
Author
|
I've moved this PR to apache/zeppelin#1 |
Leemoonsoo
pushed a commit
to Leemoonsoo/zeppelin
that referenced
this pull request
Mar 25, 2015
- This PR is from ZEPL/zeppelin#394 - Fixed indentation with 2 spaces Author: Jongyoul Lee <[email protected]> Closes #1 from jongyoul/ZEPPELIN-4 and squashes the following commits: 88e3c7a [Jongyoul Lee] [ZEPPELIN-4] Sync the version of dependencies with Spark - This PR is from ZEPL/zeppelin#394 - Fixed indentation with 2 spaces 8651077 [Jongyoul Lee] Synced some version with spark 1.3 including codehaus.jackson
Leemoonsoo
pushed a commit
to Leemoonsoo/zeppelin
that referenced
this pull request
Mar 25, 2015
- This PR is from ZEPL/zeppelin#394 - Fixed indentation with 2 spaces Author: Jongyoul Lee <[email protected]> Closes #1 from jongyoul/ZEPPELIN-4 and squashes the following commits: 88e3c7a [Jongyoul Lee] [ZEPPELIN-4] Sync the version of dependencies with Spark - This PR is from ZEPL/zeppelin#394 - Fixed indentation with 2 spaces 8651077 [Jongyoul Lee] Synced some version with spark 1.3 including codehaus.jackson
asfgit
pushed a commit
to apache/zeppelin
that referenced
this pull request
Mar 26, 2015
- This PR is from ZEPL/zeppelin#394 - Fixed indentation with 2 spaces Author: Jongyoul Lee <[email protected]> Closes #1 from jongyoul/ZEPPELIN-4 and squashes the following commits: 88e3c7a [Jongyoul Lee] [ZEPPELIN-4] Sync the version of dependencies with Spark - This PR is from ZEPL/zeppelin#394 - Fixed indentation with 2 spaces 8651077 [Jongyoul Lee] Synced some version with spark 1.3 including codehaus.jackson
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed jackson dependencies for using it and changed version to 1.9.13. and Adjusted indentations