Change text highlight color so we can see the text#170
Merged
Leemoonsoo merged 1 commit intomasterfrom Oct 23, 2014
Merged
Conversation
Contributor
|
I have tested and all looks good! can't wait. |
Contributor
Author
|
Let's Merge it then since CI build passed :) |
Leemoonsoo
added a commit
that referenced
this pull request
Oct 23, 2014
Change text highlight color so we can see the text
epahomov
pushed a commit
to epahomov/zeppelin
that referenced
this pull request
Jul 23, 2016
This PR fixes https://issues.apache.org/jira/browse/ZEPPELIN-172 Author: Lee moon soo <[email protected]> Author: Sjoerd Mulder <[email protected]> Author: Lee moon soo <[email protected]> Closes ZEPL#170 from Leemoonsoo/websocket and squashes the following commits: 11a302a [Lee moon soo] Check text in more safe way 3cf839d [Lee moon soo] Merge pull request ZEPL#2 from sjoerdmulder/websocket 7f8bc47 [Sjoerd Mulder] Cleanup of Javascript logic and Server code detecting the correct port 412927f [Lee moon soo] Handle large message f56e417 [Lee moon soo] Add license header 806db9b [Lee moon soo] Remove websocket addr/port configuration 6180ed3 [Lee moon soo] Update README 85d14a0 [Lee moon soo] Create notebookserver instance manually a7b82aa [Lee moon soo] Initial implementation of Websocket inside of Jetty server
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we highlighted the text, we couldn't see the text since background-color was applied on top of it.
This resolve the problem by adding some alpha to the color