Closed
Conversation
Nullcheck excerpt
seripap
force-pushed
the
issues/seripap/js-undefined-values
branch
from
cfab676 to
975c620
Compare
Contributor
Author
Contributor
Author
|
While this fixes nullvalue issues, there is a parent issue on the YoastSEO.js side where the script is attempting to manipulate dom elements to undefined nodes. I've opened a PR for review to address that. |
Contributor
|
Will be included in 3.0.4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was breaking my plugins because the element was never found on the page. The switch block could use a little rewrite.