Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds filter to disable including multisite xml sitemaps in robots txt #18909

Conversation

thijsoo
Copy link
Contributor

@thijsoo thijsoo commented Aug 29, 2022

Context

  • Some users don't want all multisite XML links visible in the robots.txt this PR provides a way to filter them.

Summary

This PR can be summarized in the following changelog entry:

  • Adds a filter to remove subdirectory sites from the robots.txt

Relevant technical choices:

  • The choice was made to only make a turn on or off feature, instead of a filter to actually filter the list of subsites.

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Block/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change.

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unit tests to verify the code works as intended
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.

Fixes #
PC-393

@thijsoo thijsoo added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Aug 30, 2022
@thijsoo thijsoo added this to the 19.8 milestone Aug 30, 2022
@thijsoo thijsoo marked this pull request as ready for review August 30, 2022 08:03
Copy link
Contributor

@KiOui KiOui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR & ACC: ✅

@thijsoo thijsoo merged commit 4bf89f3 into trunk Sep 1, 2022
@thijsoo thijsoo deleted the PC-393-exclude-specific-subsites-sitemap-ur-ls-from-multisite-robots-txt branch September 1, 2022 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants