Skip to content

Comments

Increase Ryte sitecheck timeout#16953

Merged
johannadevos merged 2 commits intotrunkfrom
16837-increase-ryte-timeout
May 6, 2021
Merged

Increase Ryte sitecheck timeout#16953
johannadevos merged 2 commits intotrunkfrom
16837-increase-ryte-timeout

Conversation

@Djennez
Copy link
Member

@Djennez Djennez commented May 5, 2021

Context

  • Decrease the likelyhood of a site-check by Ryte to end in a timeout.

Summary

This PR can be summarized in the following changelog entry:

  • [non-user-facing] Increase the timeout for the site-health check to Ryte from 5 to 10 seconds.

Relevant technical choices:

  • When Ryte is particularly busy, responses may exceed several seconds. Combine this with WordPress / host / networking overhead may cause the Ryte check to timeout and show an cURL 28 error.

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Have Query Monitor installed
  • Go to Tools -> Site Health
  • Check the HTTP API calls in Query Monitor
  • See that the call to https://indexability.yoast.onpage.org/ now has a timeout of 10 seconds (instead of the default 5)

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Documentation

  • I have written documentation for this change.

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unittests to verify the code works as intended

Fixes #16837

@Djennez Djennez added community-patch changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog labels May 5, 2021
@johannadevos johannadevos self-assigned this May 6, 2021
@johannadevos
Copy link
Contributor

CR & test: ✅

  • On this branch, I see that the call to https://indexability.yoast.onpage.org/ has a timeout of 10 seconds.
  • On this branch, I'm not getting a cURL error 28.
  • Without this code, I see that the call to https://indexability.yoast.onpage.org/ has a timeout of 5 seconds.
  • Without this code, I'm getting the cURL error 28: Operation timed out after 5000 milliseconds with 0 bytes received error.

@johannadevos johannadevos added this to the 16.4 milestone May 6, 2021
@johannadevos johannadevos merged commit 53bd3cd into trunk May 6, 2021
@johannadevos johannadevos deleted the 16837-increase-ryte-timeout branch May 6, 2021 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog community-patch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Increase indexability check timeout please

2 participants