Skip to content

Fix primary custom taxonomies#15078

Merged
igorschoester merged 1 commit intorelease/14.1from
fix-primary-custom-taxonomies
May 6, 2020
Merged

Fix primary custom taxonomies#15078
igorschoester merged 1 commit intorelease/14.1from
fix-primary-custom-taxonomies

Conversation

@herregroen
Copy link
Copy Markdown
Contributor

@herregroen herregroen commented May 6, 2020 •
edited by igorschoester
Loading

Summary

This PR can be summarized in the following changelog entry:

  • Fixes a bug where primary terms of a custom taxonomy where not being reflected in the breadcrumb.

Test instructions

This PR can be tested by following these steps:

  • For a custom taxonomy create multiple terms.
  • Set the alphabetically last as the primary term.
  • It should show up in the breadcrumb.
  • Change the primary term.
  • The breadcrumb should also change.
  • Ideally also test with WooCommerce and a custom taxonomy from there.

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Documentation

  • I have written documentation for this change.

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unittests to verify the code works as intended

Fixes #15071
Fixes https://github.com/Yoast/bugreports/issues/1005

@herregroen herregroen changed the base branch from trunk to release/14.1 May 6, 2020 10:02
igorschoester
igorschoester approved these changes May 6, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@igorschoester igorschoester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR & Acceptance ✅

@igorschoester igorschoester added changelog: bugfix Needs to be included in the 'Bugfixes' category in the changelog 0.5 labels May 6, 2020
@igorschoester igorschoester added this to the 14.1 milestone May 6, 2020
@igorschoester igorschoester merged commit 6f7aace into release/14.1 May 6, 2020
@igorschoester igorschoester deleted the fix-primary-custom-taxonomies branch May 6, 2020 12:18
@igorschoester igorschoester mentioned this pull request May 6, 2020
Closed
8 tasks
@igorschoester igorschoester removed the 0.5 label May 6, 2020
@IreneStr IreneStr added the innovation Innovative issue. Relating to performance, memory or data-flow. label May 7, 2020
@skunkins
Copy link
Copy Markdown

skunkins commented May 14, 2020

This issue was not resolved in my case with the 14.1 update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@igorschoester igorschoester igorschoester approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

changelog: bugfix Needs to be included in the 'Bugfixes' category in the changelog innovation Innovative issue. Relating to performance, memory or data-flow.

Projects

None yet

Milestone

14.1

Development

Successfully merging this pull request may close these issues.

primary category not being observed in breadcrumbs (Yoast)

4 participants

@herregroen @skunkins @igorschoester @IreneStr