-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP deprecated notice #21455
Comments
Please inform the customer of conversation # 1148586 when this conversation has been closed. |
Please include this customer of conversation # 1174638 when this conversation has been closed. |
Please inform the customer of conversation # 1185511 when this conversation has been closed. |
Is this going to be fixed at some point given PHP 8.1 released in 2021 and the current version is 8.3. |
Literally all that needs to be done to fix this is change line 49 to this: return \urldecode( \trim( (string) \apply_filters( 'wpseo_canonical', $this->presentation->canonical, $this->presentation ) ) ); Note that the |
Hi @monkeyArms Thank you for taking the time to check this issue and for sharing the fix! We truly appreciate your contribution and enthusiasm. We would love for you to submit your fix as a Pull Request. It will be a great way to ensure your contribution gets properly reviewed and integrated into the project by our development team. You can find more details about contributing here. I appreciate any help you can provide. |
@josevarghese this notice generates an enormous amount of noise if tools like Sentry or similar are in place. We have a composer patch to patch this up in place, but would love it if it could make it upstream. |
Hi @aanduque Thanks for the comment and for taking the time to create a Pull Request! We appreciate your contribution and will look it over as soon as possible. Your efforts to improve the project mean a lot to us. |
Please inform the customer of conversation # 1226199 when this conversation has been closed. |
Please give us a description of what happened
To Reproduce
Step-by-step reproduction instructions
PHP Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated in /wp-content/plugins/wordpress-seo/src/presenters/canonical-presenter.php on line 49
Screenshots, screen recording, code snippet
If possible, please provide a screenshot, a screen recording or a code snippet which demonstrates the bug.
Technical info
Used versions
The text was updated successfully, but these errors were encountered: