Skip to content

Conversation

@jrfnl
Copy link
Collaborator

@jrfnl jrfnl commented Jan 12, 2025

Drop support for PHP < 7.1 [1]

  • Update Composer version requirements.
  • Remove PHP 7.0 specific Composer script.
  • Stop running tests/linting in CI against PHP 7.0.

Drop support for PHP < 7.1 [2]

Remove various in-code work-arounds which were specifically to support PHP 7.0.

Drop support for PHP < 7.1 [3]

Remove the PHP 7.1+ specific test fixtures for the AssertObjectEquals and AssertObjectNotEquals tests.

As support for PHP < 7.1 has been dropped, these fixture methods no longer need their own class and can be moved into the main test fixture.

@coveralls
Copy link

coveralls commented Jan 12, 2025

Coverage Status

coverage: 97.628% (-0.3%) from 97.912%
when pulling f800be8 on 4.0/feature/drop-support-for-php-lt-7.1
into 1439d08 on 4.x.

jrfnl added 3 commits January 12, 2025 22:19
* Update Composer version requirements.
* Remove PHP 7.0 specific Composer script.
* Stop running tests/linting in CI against PHP 7.0.
Remove various in-code work-arounds which were specifically to support PHP 7.0.
Remove the PHP 7.1+ specific test fixtures for the `AssertObjectEquals` and `AssertObjectNotEquals` tests.

As support for PHP < 7.1 has been dropped, these fixture methods no longer need their own class and can be moved into the main test fixture.
@jrfnl jrfnl force-pushed the 4.0/feature/drop-support-for-php-lt-7.1 branch from 40ceca3 to f800be8 Compare January 12, 2025 21:19
Copy link
Collaborator

@hellofromtonya hellofromtonya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice LGTM 👍

@jrfnl
Copy link
Collaborator Author

jrfnl commented Jan 13, 2025

Thanks for reviewing @hellofromtonya ! Want to do the honours ?

@hellofromtonya hellofromtonya merged commit b4c70e2 into 4.x Jan 14, 2025
143 checks passed
@hellofromtonya hellofromtonya deleted the 4.0/feature/drop-support-for-php-lt-7.1 branch January 14, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants