@@ -70,6 +70,7 @@ def online_write_batch(
7070 cur = conn .cursor ()
7171
7272 project = config .project
73+ versioning = config .registry .enable_online_feature_view_versioning
7374
7475 batch_write = config .online_store .batch_write
7576 if not batch_write :
@@ -92,6 +93,7 @@ def online_write_batch(
9293 table ,
9394 timestamp ,
9495 val ,
96+ versioning ,
9597 )
9698 conn .commit ()
9799 if progress :
@@ -124,7 +126,9 @@ def online_write_batch(
124126
125127 if len (insert_values ) >= batch_size :
126128 try :
127- self ._execute_batch (cur , project , table , insert_values )
129+ self ._execute_batch (
130+ cur , project , table , insert_values , versioning
131+ )
128132 conn .commit ()
129133 if progress :
130134 progress (len (insert_values ))
@@ -135,17 +139,20 @@ def online_write_batch(
135139
136140 if insert_values :
137141 try :
138- self ._execute_batch (cur , project , table , insert_values )
142+ self ._execute_batch (cur , project , table , insert_values , versioning )
139143 conn .commit ()
140144 if progress :
141145 progress (len (insert_values ))
142146 except Exception as e :
143147 conn .rollback ()
144148 raise e
145149
146- def _execute_batch (self , cur , project , table , insert_values ):
147- sql = f"""
148- INSERT INTO { _table_id (project , table )}
150+ def _execute_batch (
151+ self , cur , project , table , insert_values , enable_versioning = False
152+ ):
153+ table_name = _table_id (project , table , enable_versioning )
154+ stmt = f"""
155+ INSERT INTO { table_name }
149156 (entity_key, feature_name, value, event_ts, created_ts)
150157 values (%s, %s, %s, %s, %s)
151158 ON DUPLICATE KEY UPDATE
@@ -154,22 +161,29 @@ def _execute_batch(self, cur, project, table, insert_values):
154161 created_ts = VALUES(created_ts);
155162 """
156163 try :
157- cur .executemany (sql , insert_values )
164+ cur .executemany (stmt , insert_values )
158165 except Exception as e :
159- # Log SQL info for debugging without leaking sensitive data
160166 first_sample = insert_values [0 ] if insert_values else None
161167 raise RuntimeError (
162- f"Failed to execute batch insert into table '{ _table_id ( project , table ) } ' "
168+ f"Failed to execute batch insert into table '{ table_name } ' "
163169 f"(rows={ len (insert_values )} , sample={ first_sample } ): { e } "
164170 ) from e
165171
166172 @staticmethod
167173 def write_to_table (
168- created_ts , cur , entity_key_bin , feature_name , project , table , timestamp , val
174+ created_ts ,
175+ cur ,
176+ entity_key_bin ,
177+ feature_name ,
178+ project ,
179+ table ,
180+ timestamp ,
181+ val ,
182+ enable_versioning = False ,
169183 ) -> None :
170184 cur .execute (
171185 f"""
172- INSERT INTO { _table_id (project , table )}
186+ INSERT INTO { _table_id (project , table , enable_versioning )}
173187 (entity_key, feature_name, value, event_ts, created_ts)
174188 values (%s, %s, %s, %s, %s)
175189 ON DUPLICATE KEY UPDATE
@@ -204,14 +218,15 @@ def online_read(
204218 result : List [Tuple [Optional [datetime ], Optional [Dict [str , Any ]]]] = []
205219
206220 project = config .project
221+ versioning = config .registry .enable_online_feature_view_versioning
207222 for entity_key in entity_keys :
208223 entity_key_bin = serialize_entity_key (
209224 entity_key ,
210225 entity_key_serialization_version = 3 ,
211226 ).hex ()
212227
213228 cur .execute (
214- f"SELECT feature_name, value, event_ts FROM { _table_id (project , table )} WHERE entity_key = %s" ,
229+ f"SELECT feature_name, value, event_ts FROM { _table_id (project , table , versioning )} WHERE entity_key = %s" ,
215230 (entity_key_bin ,),
216231 )
217232
@@ -243,10 +258,11 @@ def update(
243258 conn = self ._get_conn (config )
244259 cur = conn .cursor ()
245260 project = config .project
261+ versioning = config .registry .enable_online_feature_view_versioning
246262
247263 # We don't create any special state for the entities in this implementation.
248264 for table in tables_to_keep :
249- table_name = _table_id (project , table )
265+ table_name = _table_id (project , table , versioning )
250266 index_name = f"{ table_name } _ek"
251267 cur .execute (
252268 f"""CREATE TABLE IF NOT EXISTS { table_name } (entity_key VARCHAR(512),
@@ -269,7 +285,7 @@ def update(
269285 )
270286
271287 for table in tables_to_delete :
272- _drop_table_and_index (cur , project , table )
288+ _drop_table_and_index (cur , project , table , versioning )
273289
274290 def teardown (
275291 self ,
@@ -280,16 +296,26 @@ def teardown(
280296 conn = self ._get_conn (config )
281297 cur = conn .cursor ()
282298 project = config .project
299+ versioning = config .registry .enable_online_feature_view_versioning
283300
284301 for table in tables :
285- _drop_table_and_index (cur , project , table )
302+ _drop_table_and_index (cur , project , table , versioning )
286303
287304
288- def _drop_table_and_index (cur : Cursor , project : str , table : FeatureView ) -> None :
289- table_name = _table_id (project , table )
305+ def _drop_table_and_index (
306+ cur : Cursor , project : str , table : FeatureView , enable_versioning : bool = False
307+ ) -> None :
308+ table_name = _table_id (project , table , enable_versioning )
290309 cur .execute (f"DROP INDEX { table_name } _ek ON { table_name } ;" )
291310 cur .execute (f"DROP TABLE IF EXISTS { table_name } " )
292311
293312
294- def _table_id (project : str , table : FeatureView ) -> str :
295- return f"{ project } _{ table .name } "
313+ def _table_id (project : str , table : FeatureView , enable_versioning : bool = False ) -> str :
314+ name = table .name
315+ if enable_versioning :
316+ version = getattr (table .projection , "version_tag" , None )
317+ if version is None :
318+ version = getattr (table , "current_version_number" , None )
319+ if version is not None and version > 0 :
320+ name = f"{ table .name } _v{ version } "
321+ return f"{ project } _{ name } "
0 commit comments