-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add nonce to the logout link #3170
Copy link
Copy link
Closed
Labels
Description
The logout link doesn't check for a nonce, see:
Lines 43 to 46 in 42fd3b8
| case 'logout': | |
| // unused for the moment | |
| yourls_logout(); | |
| break; |
A mean hax0r can trick a naive user into logging out themselves if they're redirected to http://their-your.ls/admin/index.php?action=logout.
Definitely not a big deal, but also trivial to fix.
Reactions are currently unavailable