Update ampersand URL handling to ensure "A & B" becomes "A-and-B"#1620
Merged
Conversation
…becomes "A-and-B" Previously, in a forum name, "A & B" would become "AandB". The update to UrlRewriteHelper.CleanStringForUrl() addresses that. Previously, in a topic name, "A & B" would become "A--amp--B" because the topic name was being double-encoded, first in LinkBuilder.GetTopicLink/GetMessageLink functions (to "A & B"), and then again by UrlRewriteHelper.CleanStringForUrl() when called from LinkBuilder.GetLink(). Removing the first encoding is safe because all paths still call CleanStringForUrl(). Note: "A&B" becomes "A-B", same as before this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, in a forum name, "A & B" would become "AandB". The update to UrlRewriteHelper.CleanStringForUrl() addresses that.
Previously, in a topic name, "A & B" would become "A--amp--B" because the topic name was being double-encoded, first in LinkBuilder.GetTopicLink/GetMessageLink functions (to "A & B"), and then again by UrlRewriteHelper.CleanStringForUrl() when called from LinkBuilder.GetLink(). Removing the first encoding is safe because all paths still call CleanStringForUrl().
Note: "A&B" becomes "A-B", same as before this change.