use simpler 'release' instead of 'non-prerelease' word in user-facing… #239
Conversation
MattKiazyk
left a comment
MattKiazyk
left a comment
There was a problem hiding this comment.
I aggee @pastey - can we change the enum as well so devs working on the project are less confused too!
| return "Missing password. Please try again." | ||
| case let .unavailableVersion(version): | ||
| return "Could not find version \(version.appleDescription)." | ||
| case .noNonPrereleaseVersionAvailable: |
There was a problem hiding this comment.
Can't agree with you more! Can we go the next step and rename this enum as well?
| <details> | ||
| <summary>Using Xcode</summary> | ||
| Even though xcodes is a command-line app, lll of the normal functionality works in Xcode, like building, running, and running tests. You can even type text into Xcode's console when it prompts you for input like your Apple ID or 2FA code. | ||
| Even though xcodes is a command-line app, all of the normal functionality works in Xcode, like building, running, and running tests. You can even type text into Xcode's console when it prompts you for input like your Apple ID or 2FA code. |
There was a problem hiding this comment.
Fixed a small typo here. Not related to the PR, but would be nice to fix 🙏
|
@MattKiazyk, please check 🙏 |
|
Sorry @pastey can you rebase with the recent changes with runtime installs. Looks good otherwise. |
Done. Hope I did it correctly (I'm more used to plain old merge) |
|
Hey, @MattKiazyk will you have a chance to take one more look at this PR? |
1 similar comment
|
Hey, @MattKiazyk will you have a chance to take one more look at this PR? |
|
Thanks for the change! |
2 participants
… output
Hi,
Not sure if you'll find this PR useful and corresponding to your philosophy, but anyway...
I find current phrasing
Latest non-prerelease version available is...a bit too complex. I would suggest to simplify it by replacingnon-prereleaseto plain...release.I see that the same
NonPrereleaseterm is used in variable names. If you find this suggestion feasible, then I can rename variables too.Maybe you'll tell me that there's some deep idea behind
non-prerelease, then I'm fine with that too :)Thanks for the great tool that saves ton of my time!