Skip to content

Comments

Router: Fix panic in ProcessNameMatcher when source IPs are empty#5574

Merged
RPRX merged 1 commit intomainfrom
process-route
Jan 21, 2026
Merged

Router: Fix panic in ProcessNameMatcher when source IPs are empty#5574
RPRX merged 1 commit intomainfrom
process-route

Conversation

@Fangliding
Copy link
Member

close #5573
我记得写的时候反复提醒自己记得检查源IP是否为空 结果最后还是忘了(
其实 FindProcess 我最开始的是对着 net.Destination 类型写的 最后发现访问不到源地址 不过信息都存在 就拼回去传递的 拼完就忘了(
不过啥请求没有源IP呢

@RPRX
Copy link
Member

RPRX commented Jan 19, 2026

不过啥请求没有源IP呢

似乎只有内部 DNS 的请求

@RPRX
Copy link
Member

RPRX commented Jan 19, 2026

不过如果考虑到 loopback 重路由那就多了,出站有些内部请求可能没有传递 ctx

@RPRX
Copy link
Member

RPRX commented Jan 19, 2026

不过我也不确定出站有没有/有哪些内部请求以及它们是否会进 loopback,还涉及 dns 什么的,得看看文档,乱乱的

@RPRX
Copy link
Member

RPRX commented Jan 21, 2026

又想起来一个,非 VLESS 的那个通用反代可能也是没有源 IP

@RPRX RPRX changed the title Fix empty src ip Router: Fix panic in ProcessNameMatcher when source IPs are empty Jan 21, 2026
@RPRX RPRX merged commit 777e313 into main Jan 21, 2026
83 of 86 checks passed
nebulabox added a commit to nebulabox/Xray-core that referenced this pull request Jan 28, 2026
* commit 'f6a7e939231e5ec6b167628bf730dc70a3c36707': (90 commits)
  VMess inbound: Optimize replay filter (XTLS#5562)
  Bump github.com/pires/go-proxyproto from 0.9.1 to 0.9.2 (XTLS#5614)
  TUN inbound: Add iOS support (XTLS#5612)
  Geodat: Reduce peak memory usage (XTLS#5581)
  Bump github.com/pires/go-proxyproto from 0.9.0 to 0.9.1 (XTLS#5608)
  Hysteria transport: Support range & random for `interval` in `udphop` as well (XTLS#5603)
  TUN inbound: Enhance Darwin interface support (XTLS#5598)
  XUDP client: Initialize Global ID's BaseKey correctly (XTLS#5602)
  TUN inbound: Disable RACK/TLP recovery to fix connection stalls (XTLS#5600)
  v26.1.23
  common/errors/feature_errors.go: Add PrintNonRemovalDeprecatedFeatureWarning() (XTLS#5567)
  API: Add ListRule() for routing (XTLS#5569)
  Log config: More flexible `maskAddress` (XTLS#5570)
  Bump github.com/miekg/dns from 1.1.70 to 1.1.72 (XTLS#5590)
  Bump github.com/cloudflare/circl from 1.6.2 to 1.6.3 (XTLS#5589)
  Hysteria transport: Fix speedtest issue (XTLS#5587)
  README.md: Add fancyss to Asuswrt-Merlin Clients
  Router: Fix panic in ProcessNameMatcher when source IPs are empty (XTLS#5574)
  README.md: Update links for PassWall & PassWall 2 (XTLS#5572)
  Tests: Reduce RAM usage (XTLS#5577)
  ...

# Conflicts:
#	core/core.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Panic in ProcessNameMatcher when source IPs are empty

2 participants