Skip to content

Comments

common/errors/feature_errors.go: Add PrintNonRemovalDeprecatedFeatureWarning()#5567

Merged
RPRX merged 10 commits intoXTLS:mainfrom
KobeArthurScofield:NonRemovalDeprecation
Jan 23, 2026
Merged

common/errors/feature_errors.go: Add PrintNonRemovalDeprecatedFeatureWarning()#5567
RPRX merged 10 commits intoXTLS:mainfrom
KobeArthurScofield:NonRemovalDeprecation

Conversation

@KobeArthurScofield
Copy link
Contributor

针对后面很大概率不会移除的弃用内容添加一个 PrintNonRemovalDeprecatedFeatureWarning,以此取代原来默认情况下不会显示且没什么用的 PrintMigrateFeatureInfo

同时将传输层及用于出站配置的代理协议提示从原来的 PrintDeprecatedFeatureWarning 换成新的提示

@RPRX
Copy link
Member

RPRX commented Jan 18, 2026

虽然加了提示的那些实际上都很难移除,但说要移除主要是用来吓人的

@RPRX
Copy link
Member

RPRX commented Jan 18, 2026

话说这个说明我还得优化下

@KobeArthurScofield
Copy link
Contributor Author

可以,都可以

@RPRX
Copy link
Member

RPRX commented Jan 18, 2026

不是说优化这个 PR 而是给出刚添加那些 warning 的详细解释,这个 PR 可能会被 close

@KobeArthurScofield
Copy link
Contributor Author

原来那个被顶掉的函数本来也没用,不过要吓人的话可以两个都吓,可以做些细微差异

@KobeArthurScofield
Copy link
Contributor Author

不然说删挂了两年都不删后面可能就没什么威慑力了

@yuhan6665
Copy link
Member

Please, don't remove allowinsecure options.
There are many devices that cannot correct verify a certificate.
There are many use cases that demand a tls encryption over the traffic, but user does not care if being MITM.

@RPRX
Copy link
Member

RPRX commented Jan 19, 2026

严格来说 allowInsecure 并非被彻底移除,并非禁止自签,它只是被迁移到了甚至比系统 CA 更安全的 pinnedPeerCertSha256

分享链接标准从一开始就没有 allowInsecure 这么多年了也没问题,pinnedPeerCertSha256 实际上还是放开了自签证书的分享

昨天分享链接标准已加入 pcs@yuhan6665 可以更新一下 NG,我们可以逐步推动它取代 allowInsecure

人话说就是一开始搞出 allowInsecure 的真是人才,但凡把它搞成 pin 也不至于形成某些完全跳过证书验证的使用习惯

至于禁止未加密公网出站我都觉得可以趁着伊朗断网直接上了,因为这东西只有伊朗会用

@RPRX RPRX changed the title Errors: Add PrintNonRemovalDeprecatedFeatureWarning common/errors/feature_errors.go: Add PrintNonRemovalDeprecatedFeatureWarning() Jan 23, 2026
@RPRX RPRX merged commit cd8aab9 into XTLS:main Jan 23, 2026
39 checks passed
@KobeArthurScofield KobeArthurScofield deleted the NonRemovalDeprecation branch January 23, 2026 16:28
nebulabox added a commit to nebulabox/Xray-core that referenced this pull request Jan 28, 2026
* commit 'f6a7e939231e5ec6b167628bf730dc70a3c36707': (90 commits)
  VMess inbound: Optimize replay filter (XTLS#5562)
  Bump github.com/pires/go-proxyproto from 0.9.1 to 0.9.2 (XTLS#5614)
  TUN inbound: Add iOS support (XTLS#5612)
  Geodat: Reduce peak memory usage (XTLS#5581)
  Bump github.com/pires/go-proxyproto from 0.9.0 to 0.9.1 (XTLS#5608)
  Hysteria transport: Support range & random for `interval` in `udphop` as well (XTLS#5603)
  TUN inbound: Enhance Darwin interface support (XTLS#5598)
  XUDP client: Initialize Global ID's BaseKey correctly (XTLS#5602)
  TUN inbound: Disable RACK/TLP recovery to fix connection stalls (XTLS#5600)
  v26.1.23
  common/errors/feature_errors.go: Add PrintNonRemovalDeprecatedFeatureWarning() (XTLS#5567)
  API: Add ListRule() for routing (XTLS#5569)
  Log config: More flexible `maskAddress` (XTLS#5570)
  Bump github.com/miekg/dns from 1.1.70 to 1.1.72 (XTLS#5590)
  Bump github.com/cloudflare/circl from 1.6.2 to 1.6.3 (XTLS#5589)
  Hysteria transport: Fix speedtest issue (XTLS#5587)
  README.md: Add fancyss to Asuswrt-Merlin Clients
  Router: Fix panic in ProcessNameMatcher when source IPs are empty (XTLS#5574)
  README.md: Update links for PassWall & PassWall 2 (XTLS#5572)
  Tests: Reduce RAM usage (XTLS#5577)
  ...

# Conflicts:
#	core/core.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants