Change PinnedPeerCertSha256 from array to tilde-separated string#5507
Merged
Change PinnedPeerCertSha256 from array to tilde-separated string#5507
Conversation
Co-authored-by: RPRX <[email protected]>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Refactor certificate pin logic
Change PinnedPeerCertSha256 from array to pipe-separated string
Jan 8, 2026
Member
|
@copilot |
Co-authored-by: RPRX <[email protected]>
Contributor
Author
Member
|
@copilot 把分隔符 |
Co-authored-by: RPRX <[email protected]>
Member
|
@copilot 算了还是用 |
Contributor
Author
Copilot
AI
changed the title
Change PinnedPeerCertSha256 from array to pipe-separated string
Change PinnedPeerCertSha256 from array to underscore-separated string
Jan 8, 2026
Co-authored-by: RPRX <[email protected]>
Contributor
Author
Copilot
AI
changed the title
Change PinnedPeerCertSha256 from array to underscore-separated string
Change PinnedPeerCertSha256 from array to tilde-separated string
Jan 9, 2026
RPRX
added a commit
that referenced
this pull request
Jan 9, 2026
…ChainSha256` and `pinnedPeerCertificatePublicKeySha256` (#5154) Usage: #5507 --------- Co-authored-by: Copilot <[email protected]> Co-authored-by: RPRX <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed the
PinnedPeerCertSha256configuration field from a string array to a single string accepting multiple SHA-256 hashes separated by~.Changes
*[]stringtostringininfra/conf/transport_internet.gopinnedPeerCertSha256)~separator, trim whitespace, skip empty valuesUsage
{ "tlsSettings": { "pinnedPeerCertSha256": "AE243D668EC9C7F74A0DCD1AD21C6676B4EFE30C39728934B362093AF886BF77" } }Multiple hashes:
{ "tlsSettings": { "pinnedPeerCertSha256": "hash1~hash2~hash3" } }This format simplifies share link encoding and UI implementation while maintaining support for multiple pinned certificates. The tilde separator doesn't require URL encoding and is visually distinct, making it ideal for share links and configuration files.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.