Remove redundant stats in mux and bridge dispatcher #5466
Merged
Conversation
Member
|
这样改的话似乎会影响 @wyx2685 |
Contributor
|
居然被@了 |
Member
Author
|
我理解不在 dispatch 时候 cast dispatcher 就行 既然要删掉 那顺便 refactor |
Contributor
|
这里对于自定义的 DefaultDispatcher 会有类型兼容性问题的 这是上一次 @Fangliding 风筝当时做的兼容性重构。 f9dd3ae#diff-35b30f4c19a774a865d83f273a0a5f8a6925c96d6c3f4e6bbf2aaca850705b62R78-R93 重构 type Handler struct {
// ...
dispatcher routing.WrapLinkDispatcher
// ...
} handler := &Handler{
// ...
dispatcher: v.GetFeature(routing.DispatcherType()).(routing.WrapLinkDispatcher),
// ...
} if request.Command == protocol.RequestCommandRvs {
r, err := h.GetReverse(account)
if err != nil {
return err
}
return r.NewMux(ctx, h.dispatcher.WrapLink(ctx, &transport.Link{Reader: clientReader, Writer: clientWriter}))
} |
This reverts commit f9dd3ae.
Since mux will add traffic stats in sub connection's dispatch function Adding additional stats result to double counting
Member
Author
|
@xtlsee 行吧 给你改成 interface 了 |
Contributor
|
@yuhan6665 牛逼,大神。优雅 |
Member
|
|
Member
|
|
This was referenced Jan 13, 2026
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #5446
I'm not sure about vless inbound calling WrapLink() for RequestCommandRvs.
Please take a look @Fangliding @RPRX